Review main Merged

77913[BUGFIX] Fix PHP Warning in GraphicalFunctions

Thomas Hohn CR +2 V +2 Easy +4 −1 updated 02/27/23, 19:33

Commit message

Added a missing else case in getImageDimensions when image size
can't be determined. Return null instead of a boolean.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Thomas Hohn uploaded patch set 1 02/21/23, 09:41

  2. core-ci voted on patch set 1 V +1 02/21/23, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37918

  3. Oliver Klee voted on patch set 1 CR +1 02/21/23, 10:27

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 02/27/23, 14:21

  5. Stefan Bürk voted on patch set 1 V +2 CR +2 02/27/23, 19:33

  6. Stefan Bürk merged patch set 2 02/27/23, 19:33