Review main Merged

77914[BUGFIX] Fix PHP 8 warning in ElementHistoryController

Thomas Hohn CR +2 V +2 Easy +6 −1 updated 02/27/23, 14:18

Commit message

If $elementUid is 0 in ElementHistoryController::getEditLockFromElement
it must be handled seperatly since the call to BackendUtility::getRecord
will return null.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Thomas Hohn uploaded patch set 1 02/21/23, 12:26

  2. core-ci voted on patch set 1 V +1 02/21/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37922

  3. Stefan Bürk commented on patch set 1 02/23/23, 09:47

    ElementHistoryController.php:455

    Inner if can be simplyfied by ``` return !($GLOBALS['TCA'][$tableName]['ctrl']['security']['ignoreRootLevelRestriction'] ?? false); ```
  4. Thomas Hohn uploaded patch set 2 V +1 02/23/23, 10:18

  5. Thomas Hohn commented on patch set 2 02/23/23, 10:19

    ElementHistoryController.php:455 Reply

    Done
  6. core-ci voted on patch set 2 V +1 02/23/23, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38001

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 02/23/23, 11:15

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 02/27/23, 14:18

  9. Christian Kuhn merged patch set 3 02/27/23, 14:18