Review main Merged

77915[TASK] Add iterable type to `PageErrorHandlerInterface::handlePageError`

Elias Häußler CR +2 V +2 Easy +3 −0 updated 07/04/23, 15:57

Commit message

The `PageErrorHandlerInterface` is often implemented in case a custom
error handler is used in site configuration. Static code analysis may
complain about missing iterable types in implementations. Thus, we now
provide the iterable types to ease the implementation effort in TYPO3
projects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Elias Häußler uploaded patch set 1 02/21/23, 12:49

  2. core-ci voted on patch set 1 V +1 02/21/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37925

  3. Benni Mack updated the commit message in patch set 2 V +1 05/03/23, 09:32

  4. Oliver Hader rebased onto patch set 3 05/03/23, 11:53

  5. core-ci voted on patch set 3 V +1 05/03/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41515

  6. Susi Moog voted on patch set 3 CR +1 07/04/23, 10:10

  7. Benni Mack voted on patch set 3 CR +1 07/04/23, 10:14

  8. Susi Moog voted on patch set 3 V +1 07/04/23, 15:38

  9. Oliver Klee voted on patch set 3 V +1 CR +1 07/04/23, 15:54

  10. Benni Mack voted on patch set 3 V +2 CR +2 07/04/23, 15:57

  11. Benni Mack merged patch set 4 07/04/23, 15:57