Review main Merged

77917[BUGFIX] Use backend specific visibility aspect in PreviewUriBuilder

Oli Bartsch CR +2 V +2 Easy +8 −1 updated 02/22/23, 11:05

Commit message

The PreviewUriBuilder is used in the backend to generate
frontend URLs. Besides passing the exact page id, it's
also possible to pass the default page id and the desired
language id. In such cases, the PageRouter is responsible
to resolve the id of the translated page. This is internally
done, using the PageRepository. However, due to a missing
visibility context does the PageRepository apply the
whole FrontendRestrictionContainer, including start-
and endtime restrictions.

This is now fixed by passing a backend specific visibility
aspect to the PreviewUriBuilder.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 02/21/23, 13:50

  2. core-ci voted on patch set 1 V +1 02/21/23, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37927

  3. Oli Bartsch uploaded patch set 2 V +1 02/21/23, 17:49

  4. core-ci voted on patch set 2 V +1 02/21/23, 17:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37940

  5. Jochen Roth voted on patch set 2 V +1 CR +1 02/22/23, 09:11

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 02/22/23, 10:58

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 02/22/23, 11:05

  8. Oli Bartsch merged patch set 3 02/22/23, 11:05