77919[TASK] Update to PHPStan 1.10.1
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 1
Files 3
Review log 1113
-
Oliver Klee uploaded patch set 1 02/21/23, 17:05
-
core-ci voted on patch set 1 V +1 02/21/23, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37937
-
Stefan Bürk voted on patch set 1 V +1 CR +1 02/21/23, 17:33
-
Benni Mack voted on patch set 1 V +1 CR +1 02/22/23, 07:24
-
Oliver Klee commented on patch set 1 CR -1 02/22/23, 07:49
Please wait, I’ll re-run with the just-released PHPStan 1.10.1. -
Benni Mack commented on patch set 1 02/22/23, 08:05
Reply
maybe we should wait until another release? PHPstan is known for releasing multiple times per day... -
Oliver Klee commented on patch set 1 CR 0 02/22/23, 08:10
The 1.10.1 update does not change the baseline. So this change will still make the nightly build green again. -
Oliver Klee commented on patch set 1 02/22/23, 08:11
Reply
I'd propose to wait until evening (so with or without the release we'll have a green nightly.) -
Oliver Klee commented on patch set 1 02/22/23, 08:11
Reply
Note: 1.10.1 does not change the baseline. -
Oliver Klee uploaded patch set 2
CR +1V +102/22/23, 08:55 -
core-ci voted on patch set 2 V +1 02/22/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37957
-
Christian Kuhn commented on patch set 2 V +2 CR +2 02/22/23, 09:15
Reply
Done -
Christian Kuhn merged patch set 3 02/22/23, 09:15