77921[FEATURE] Add method to change page cache expiration
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 2
Review log 45
-
Christoph Lehmann uploaded patch set 1 02/21/23, 21:28
-
Christoph Lehmann marked it work in progress 02/21/23, 21:29
-
core-ci voted on patch set 1 V +1 02/21/23, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37944
-
Sybille Peters commented on patch set 1 02/22/23, 03:45
Compared with the other solution which now uses the event https://review.typo3.org/c/Packages/TYPO3.CMS/+/77894 - from the client end it is more convenient because there is less to implement (no Event Listener etc. - from the code structure I am less sure. The event now also makes it possible to set the cache tags which means you would no longer have to call the public function for that in the future, you can do it all in one place and it has a clear interface. Apart from that I don't have a stake in either - would be ok if we go that way. Should add a changelog .rst file though, ideally with code example for client. You can use the ReST helper (which helps to create a file name from the title etc.): https://forger.typo3.com/utilities/rst -
Christoph Lehmann abandoned the change 03/14/23, 17:46