Review main Merged

77922[TASK] Update display of scheduler task list

Jasmina Ließmann CR +2 V +2 Normal +88 −68 updated 03/16/23, 09:53

Commit message

To avoid an inconsistent appearance, the table columns in the planner
table are given minimum widths and their content is positioned
vertically. Furthermore, the state color of deactivated task groups
and tasks changes from 'warning' to 'info'.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1320

  1. Jasmina Ließmann uploaded patch set 1 02/21/23, 22:01

  2. core-ci voted on patch set 1 V +1 02/21/23, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37945

  3. Jasmina Ließmann uploaded patch set 2 V +1 02/27/23, 18:35

  4. core-ci voted on patch set 2 V -1 02/27/23, 18:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38167

  5. Jasmina Ließmann uploaded patch set 3 V -1 02/27/23, 19:28

  6. core-ci voted on patch set 3 V +1 02/27/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38170

  7. Jasmina Ließmann uploaded patch set 4 V +1 02/27/23, 20:19

  8. Jasmina Ließmann updated the commit message in patch set 5 02/27/23, 20:25

  9. core-ci voted on patch set 4 V +1 02/27/23, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38173

  10. core-ci voted on patch set 5 V +1 02/27/23, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38174

  11. Jasmina Ließmann uploaded patch set 6 V +1 03/13/23, 18:18

  12. core-ci voted on patch set 6 V +1 03/13/23, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38885

  13. Jasmina Ließmann updated the commit message in patch set 7 V +1 03/13/23, 18:39

  14. core-ci voted on patch set 7 V +1 03/13/23, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38886

  15. Benni Mack commented on patch set 7 V +1 CR +1 03/16/23, 08:25

    _table.scss:82

    not a fan of introducing more hard-coded pxs (I'm more a "vw" and "em" guy), but I think this is totally fine for the time being here as this view already has a lot of hardcoded pxes..
  16. Josef Glatz voted on patch set 7 V +1 CR +1 03/16/23, 09:39

  17. Markus Klein voted on patch set 7 V +1 CR +1 03/16/23, 09:40

  18. Jasmina Ließmann commented on patch set 7 03/16/23, 09:48

    _table.scss:82 Reply

    I'm not really happy with this solution either. I'll try a way that Benji suggested to me once the patch for editing task groups in the scheduler module is ready.
  19. Benni Mack voted on patch set 7 V +2 CR +2 03/16/23, 09:53

  20. Benni Mack merged patch set 8 03/16/23, 09:53