Review main Merged

77927[BUGFIX] Skip numeric cookie names in RequestTokenMiddleware

Oliver Hader CR +2 V +2 Easy +2 −2 updated 02/23/23, 07:54

Commit message

Using an HTTP header like `Cookie: 1=string` results in having
a numeric key in the super-global $_COOKIE array.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oliver Hader uploaded patch set 1 02/22/23, 10:11

  2. core-ci voted on patch set 1 V +1 02/22/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37962

  3. Oliver Klee voted on patch set 1 CR +1 02/22/23, 11:09

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 02/22/23, 16:20

  5. Oliver Hader voted on patch set 1 V +2 CR +2 02/23/23, 07:54

  6. Oliver Hader merged patch set 2 02/23/23, 07:54