Review 11.5 Merged

77928[BUGFIX] Apply backend specific visibility option

Oli Bartsch CR +2 V +2 Easy +25 −0 updated 02/23/23, 11:06

Commit message

The PreviewUriBuilder is used in the backend to generate
frontend URLs. Besides passing the exact page id, it's
also possible to pass the default page id and the desired
language id. In such cases, the PageRouter is responsible
to resolve the id of the translated page. This is internally
done, using the PageRepository. However, due to a missing
visibility context does the PageRepository apply the
whole FrontendRestrictionContainer, including start-
and endtime restrictions.

This is now fixed by passing a backend specific visibility
option, which is evaluated by the PageRepository.

Note: In v12 this is done via the "visibility" aspect. In
v11, the "includeScheduledRecords" option is not available.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • Jochen Roth +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Oli Bartsch uploaded patch set 1 02/22/23, 12:20

  2. Oli Bartsch updated the commit message in patch set 2 02/22/23, 12:21

  3. Andreas Kienast voted on patch set 2 CR +1 02/22/23, 12:24

  4. Benni Mack commented on patch set 2 CR -1 02/22/23, 12:30

    BackendUtility.php:3699

    just call it ADMCMD_simSchedulewdRecords. Also, you need to exclude this in CacheHashCalculator now
  5. core-ci voted on patch set 2 V +1 02/22/23, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37968

  6. core-ci voted on patch set 1 V +1 02/22/23, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37967

  7. Oli Bartsch commented on patch set 2 02/22/23, 15:27

    BackendUtility.php:3699 Reply

    This is a special parameter which will never be added to the final URL. Same as fpr the "_language" Parameter. It gets unset by the PageRouter before building the URL.
  8. Benni Mack commented on patch set 2 CR +1 02/22/23, 15:51

    BackendUtility.php:3699 Reply

    Done
  9. Jochen Roth voted on patch set 2 V +1 CR +1 02/22/23, 16:46

  10. Daniel Goerz voted on patch set 2 V +1 CR +1 02/23/23, 07:28

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 02/23/23, 11:06

  12. Oli Bartsch merged patch set 3 02/23/23, 11:06