77935[TASK] Add option counter to LiveSearch
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/component/_livesearch.scss+8 −0
- Build/Sources/TypeScript/backend/live-search/element/search-option-item.ts+13 −0
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+15 −2
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+4 −0
- typo3/sysext/backend/Resources/Private/Templates/LiveSearch/Form.html+5 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/search-option-item.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
Review log 1318
-
Andreas Kienast uploaded patch set 1 02/23/23, 10:24
-
Andreas Kienast uploaded patch set 2 02/23/23, 10:28
-
core-ci voted on patch set 1 V -1 02/23/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38002
-
core-ci voted on patch set 2 V -1 02/23/23, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38003
-
Andreas Kienast uploaded patch set 3
V -102/23/23, 10:42 -
core-ci voted on patch set 3 V +1 02/23/23, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38006
-
Stefan Bürk commented on patch set 3 V -1 02/23/23, 11:28
Sry .. I get javascript erros in the console if selecting/unselecting options in the drop down (thus not changing the number on the fly). I cleared every cache, tmp files and browser cache and enforced reload it multiple times. https://postimg.cc/XXNgP3X1 -
Andreas Kienast uploaded patch set 4
V +102/23/23, 14:28 -
Andreas Kienast commented on patch set 4 02/23/23, 14:28
Reply
Interesting, I cannot reproduce your issue. Which browser do you use? -
core-ci voted on patch set 4 V +1 02/23/23, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38023
-
Stefan Bürk commented on patch set 4 02/23/23, 15:16
Reply
chrome / linux .. good point, will recheck later and also with another browser -
Andreas Kienast commented on patch set 4 02/24/23, 09:22
Reply
That's definitely odd. I'm on Fedora 37 with Chrome 110.0.5481.100. I tested this also with Firefox 110.0 and cannot reproduce the issue you're facing. -
Stefan Bürk commented on patch set 4 V +1 CR +1 02/24/23, 11:21
Reply
We looked into it, it's reproducable. However, unrelated to this change. Therefore, solving this comment chain now. Andreas will push a proper bugfix for this (unrelated) bug soonish. >> reduced motion animation / timeing issue -
Andreas Kienast uploaded patch set 5
CR +1V +103/01/23, 08:56 -
core-ci voted on patch set 5 V +1 03/01/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38251
-
Simon Schaufelberger voted on patch set 5 V +1 CR +1 03/01/23, 09:20
-
Georg Ringer voted on patch set 5 V +2 CR +2 03/01/23, 11:07
-
Georg Ringer merged patch set 6 03/01/23, 11:07