Review main Merged

77941[BUGFIX] Avoid timing issue when loading LiveSearch form

Andreas Kienast CR +2 V +2 Normal +77 −55 updated 03/09/23, 13:21

Commit message

There was a timing issue related to the LiveSearch form.
`Modal.advanced()` invokes an AJAX request, while the event handler for
`typo3-modal-shown` expects that the request sent a response.

This might not be the case when either the network is slow or animations
are disabled as the event is always faster dispatched than the request
can send a response.

The generic handling is now moved into an `ajaxCallback`, executed when
fetching the data finished. To be able to still focus the search field
and mark its content, event handlers for 'modal-loaded' and
'typo3-modal-shown' events are installed, as both events may be
dispatched in any order.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Andreas Kienast uploaded patch set 1 02/24/23, 12:18

  2. core-ci voted on patch set 1 V +1 02/24/23, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38051

  3. Stefan Bürk commented on patch set 1 V +1 CR +1 02/24/23, 12:40

    Thanks for fixing that.
  4. Benni Mack voted on patch set 1 V +1 CR +1 02/24/23, 13:20

  5. Andreas Kienast commented on patch set 1 CR -1 02/24/23, 13:21

    have to check something, will either merge or push again
  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 02/24/23, 14:25

  7. core-ci voted on patch set 2 V +1 02/24/23, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38057

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 02/24/23, 15:09

  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 03/06/23, 13:41

  10. core-ci voted on patch set 3 V +1 03/06/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38549

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 03/06/23, 14:00

  12. Andreas Kienast uploaded patch set 4 CR +1 V +1 03/09/23, 11:37

  13. core-ci voted on patch set 4 V +1 03/09/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38693

  14. Georg Ringer voted on patch set 4 V +2 CR +2 03/09/23, 13:21

  15. Georg Ringer merged patch set 5 03/09/23, 13:21