Review 11.5 Merged

77945[BUGFIX] Add correct diff source values to translated record

Stefan Bürk CR +2 V +2 Normal +114 −24 updated 02/25/23, 12:29

Commit message

This change ensures that the original language record diff source
(usually in the field l10n_diffsource as configured by
transOrigDiffSourceField) is set correctly as soon as a localized
record is created.

To guard this, an additional test for pages is added, and several
DataHandler tests are adjusted.

TYPO3 displays the source language value of a field for a translated
record. This information field can display a diff, if the source record
value was changed. To accomplish this a shadow copy of localizable
fields from the source language record is saved in the configurable
language diff source field.

Localization of a record creates a new record, adding the values of
localizable fields value with a prefix and setting needed system fields
like parent record id, language id and so on. This is updated if a
localized field is changed in the localized language.

`\TYPO3\CMS\Core\DataHandling\DataHandler` as the main actor in the
backend is responsible for maintaining this source diff field along
with other tasks. Due to an oversight, the source language record data
was not set during record localization. Because of this, the field
source display did not work until the localized record was saved again.
This probably went undetected because in normal editorial work the
record would be changed straight away.

Extension authors using DataHandler hooks can influence which data is
written, for example using translation tools and databases to localize
records automatically during the translation process. Therefore, it is
not really mandatory to change the value afterwards. In the past, that
practice lead to a broken and invalid source diff field. The issue
existed for pages and other records in the same way.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 12

Review log 34

  1. Stefan Bürk uploaded patch set 1 02/25/23, 12:18

  2. core-ci voted on patch set 1 V +1 02/25/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38087

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 02/25/23, 12:29

  4. Stefan Bürk merged patch set 2 02/25/23, 12:29