Review main Merged

77947[BUGFIX] Add missing matomo tracking parameters

Simon Schaufelberger CR +2 V +2 Easy +15 −1 updated 02/28/23, 13:13

Commit message

Matomo comes with some custom tracking parameters
which should be excluded from cHash generation by default.
Previously they were prefixed with pk_ from Piwik but with
the name change, new parameters have been introduced.

Matomo tracking parameters in default instance:
mtm_campaign, mtm_keyword

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Simon Schaufelberger uploaded patch set 1 02/26/23, 07:32

  2. Simon Schaufelberger commented on patch set 1 02/26/23, 07:34

    Should we deprecate the pk_ prefix as well?
  3. core-ci voted on patch set 1 V +1 02/26/23, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38110

  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/26/23, 09:43

  5. Simon Schaufelberger commented on patch set 1 02/26/23, 10:39

    DefaultConfiguration.php:1382

    Should we deprecate the pk_ prefix as well?
  6. Benni Mack updated the commit message in patch set 2 CR +1 V +1 02/27/23, 09:30

  7. core-ci voted on patch set 2 V +1 02/27/23, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38146

  8. Benni Mack commented on patch set 2 V +1 02/27/23, 09:41

    DefaultConfiguration.php:1382 Reply

    don't think so. also, deprecating seems a bit hard. I'd rather remove them with v13 with an important.rst
  9. Benni Mack commented on patch set 2 02/27/23, 09:41

    DefaultConfiguration.php:1382 Reply

    Done
  10. Guido Schmechel voted on patch set 2 CR +1 02/27/23, 12:43

  11. Josef Glatz voted on patch set 2 V +1 CR +1 02/27/23, 20:23

  12. Georg Ringer voted on patch set 2 V +2 CR +2 02/28/23, 13:13

  13. Georg Ringer merged patch set 3 02/28/23, 13:13