Review main Merged

77948[BUGFIX] Avoid useless database updates in DataHandler

Andreas Kienast CR +2 V +2 Easy +6 −5 updated 03/01/23, 09:50

Commit message

DataHandler has an internal check that compares the sent payload with
the state of the affected database record and removes fields from the
payload that didn't change.

Everytime a database record is updated, DataHandler resets the internal
stage to "0" to start a new editing workflow, if the affected database
table supports workspaces. This handling is unfortunately executed
*after* the payload comparison is done, leading to a payload that
always instructs to update the field `t3ver_stage`, even if the change
is not necessary, leading to superfluous database updates. This has a
massive negative performance impact in simple shared hosting
environments, especially with tt_content records that have many
file references attached.

The payload comparison is now executed after setting `t3ver_stage` to
filter out superfluous updates.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1