77956[BUGFIX] Fix PHP 8 warning in TypoLinkCodecService
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 1
Files 3
Review log 911
-
Benni Mack commented on patch set 1 02/24/23, 15:41
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/LinkHandling/TypoLinkCodecService.php * typo3/sysext/frontend/Classes/Typolink/LinkFactory.php -
core-ci voted on patch set 1 V -1 02/24/23, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38064
-
Benni Mack uploaded patch set 2
V -103/13/23, 22:39 -
Benni Mack marked it ready for review 03/13/23, 22:40
-
core-ci voted on patch set 2 V +1 03/13/23, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38893
-
Oliver Klee commented on patch set 2 03/13/23, 23:01
TypoLinkCodecService.php:75Should we then have a `@todo` for adding the native `string` type declaration for the parameter so we won’t forget it in V13? -
Thomas Hohn commented on patch set 2 03/14/23, 05:39
TypoLinkCodecService.php:75ReplyI believe there is a todo on the main branch @todo Remove the |null and make the signature strict typed in v13 as string -
Benni Mack commented on patch set 2 03/14/23, 06:54
TypoLinkCodecService.php:75ReplyThe todo is really irrelevant for v11 branch, as we only search for todos in main branch. -
Benni Mack voted on patch set 2 V +2 CR +2 03/14/23, 06:55
-
Benni Mack merged patch set 3 03/14/23, 06:55
-
Oliver Klee commented on patch set 3 CR +1 03/14/23, 09:35
TypoLinkCodecService.php:75ReplyOh, I totally missed that this was the 11.5 change when I wrote this comment. Thanks for pointing this out!