77988[TASK] Remove checkSimilar property in DataHandler
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Christian Kuhn uploaded patch set 1 03/01/23, 09:58
-
core-ci voted on patch set 1 V +1 03/01/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38255
-
Georg Ringer commented on patch set 1 CR -1 03/01/23, 11:09
it was possible to set this from outside which would now break because of adding a dynamic property. what about a clean approach with removing the usage and deprecate it properly? otherwise just ignore the -1 ;) -
Christian Kuhn commented on patch set 1 03/01/23, 11:12
Reply
The property has been declared @internal in v10 with a .rst file. This is not a breaking change, imho. And there is most likely no reason to change it to false in the first place. -
Georg Ringer commented on patch set 1 V +1 CR +1 03/01/23, 11:17
Reply
ah missed that info (Was just reading ^^, mea culpa) -
Christian Kuhn commented on patch set 1 03/01/23, 11:23
Reply
thanks! always good to have many eyes on patches! -
Stefan Bürk voted on patch set 1 V +2 CR +2 03/01/23, 11:59
-
Stefan Bürk merged patch set 2 03/01/23, 11:59
-
Markus Klein commented on patch set 2 04/24/23, 11:34
post -2 This flag is essential for external code! This allows to avoid a huge amount of select select-statements when content is fed from external. -
Stefan Bürk commented on patch set 2 04/24/23, 13:05
Reply
Using a `@internal` public property externally ? Correct me, but that would mean that it sends superflous update calls later without really changing something ? (or I guess updating the tsstamp for nothing) if something is similar. However, you have the information before putting it into the datahander. Sort the similar out in your own code I would say - avoids superflous selects and updates, and also access checkes etc.