Review main Merged

78001[BUGFIX] Fix migration example for GeneralUtility::_GPmerged()

Torben Hansen CR +2 V +2 Easy +1 −1 updated 03/02/23, 08:20

Commit message

The migration example code is wrong, since the request
object has no method named `getQueryString()`. Instead,
`getQueryParams()` must be used.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Thomas Hohn +1
    • Markus Klein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Thomas Hohn +1
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Torben Hansen uploaded patch set 1 03/02/23, 07:45

  2. core-ci voted on patch set 1 V +1 03/02/23, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38291

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/02/23, 07:56

  4. Markus Klein voted on patch set 1 V +1 CR +1 03/02/23, 08:01

  5. Thomas Hohn voted on patch set 1 V +1 CR +1 03/02/23, 08:04

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/02/23, 08:20

  7. Christian Kuhn merged patch set 2 03/02/23, 08:20