Review main Abandoned

78006[FEATURE] Add PSR-14 event for absolute path resolving

Nikita Hovratov CR 0 V 0 Hard +318 −36 updated 03/04/23, 14:39

Commit message

This patch adds the new AbsolutePathResolvingEvent, which can be used
to implement custom logic for path resolving. Right now the core only
knows about extension paths with the `EXT:` prefix. Now it is possible
to extend this behaviour with own prefixes or with something completely
different.

The GU::getFileAbsFileName method is refactored, so that it is easily
to place the event after EXT: paths and absolute paths checks.

In contrast to EXT: paths, sanity checks are performed for custom
absolute paths.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 13

Review log 1321

  1. Nikita Hovratov uploaded patch set 1 03/02/23, 16:05

  2. Nikita Hovratov updated the commit message in patch set 2 03/02/23, 16:05

  3. core-ci voted on patch set 1 V -1 03/02/23, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38310

  4. core-ci voted on patch set 2 V -1 03/02/23, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38311

  5. Nikita Hovratov uploaded patch set 3 V -1 03/02/23, 16:54

  6. Nikita Hovratov uploaded patch set 4 03/02/23, 16:55

  7. core-ci voted on patch set 4 V +1 03/02/23, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38314

  8. Nikita Hovratov uploaded patch set 5 V +1 03/02/23, 17:07

  9. core-ci voted on patch set 5 V +1 03/02/23, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38315

  10. Nikita Hovratov uploaded patch set 6 V +1 03/02/23, 19:26

  11. core-ci voted on patch set 6 V +1 03/02/23, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38325

  12. Oli Bartsch commented on patch set 6 03/02/23, 19:47

    GeneralUtility.php:2608

    Please let's use the EventDispatcherInterface. Also let's just use makeInstance instead of those checks for the container.
  13. Nikita Hovratov uploaded patch set 7 V +1 03/03/23, 11:06

  14. Nikita Hovratov commented on patch set 7 03/03/23, 11:07

    GeneralUtility.php:2608 Reply

    Done
  15. core-ci voted on patch set 7 V -1 03/03/23, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38350

  16. Nikita Hovratov uploaded patch set 8 V -1 03/03/23, 11:39

  17. Nikita Hovratov uploaded patch set 9 03/03/23, 11:39

  18. core-ci voted on patch set 9 V +1 03/03/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38353

  19. Chris Müller uploaded patch set 10 V +1 03/03/23, 13:06

  20. core-ci voted on patch set 10 V +1 03/03/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38358

  21. Nikita Hovratov abandoned the change 03/04/23, 14:39

    Don't add events inside GeneralUtility.