Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
78017[TASK] Make the ErrorHandler log the request url
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/17/78017/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/17/78017/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Sybille Peters +1
- Christian Kuhn -1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 3
Review log 1112
-
Rémy DANIEL uploaded patch set 1 03/03/23, 16:46
-
Rémy DANIEL marked it work in progress 03/03/23, 16:47
-
Rémy DANIEL commented on patch set 1 03/03/23, 16:48
-
Rémy DANIEL commented on patch set 1 03/03/23, 16:52
Unresolved
I would also like to know if the test coverage of the trait is okay if it remains in the ProductionExceptionHandlerTest or if it needs a test refactoring. -
core-ci voted on patch set 1 V +1 03/03/23, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38366
-
Christian Kuhn commented on patch set 1 CR -1 03/03/23, 17:23
ErrorHandler.php:141we shouldn'd add calls to GU::getIndpEnv() since this adds a technical debt to and API that should vanish. using globals['tyop3_request'] is no suitable solution, either. -
Rémy DANIEL commented on patch set 1 03/03/23, 18:27
This change is ready for review.ErrorHandler.php:141ReplyOK. But GU::getIndpEnv() is already used like that in AbstractExceptionHandler. Until there is a good replacement, I would like to use it also in ErrorHandler. -
Rémy DANIEL commented on patch set 1 09/21/23, 20:57
ErrorHandler.php:141ReplyLolli, can we just use the same (yet unperfect) API than in \TYPO3\CMS\Core\Error\AbstractExceptionHandler::writeLogEntries? -
Oli Bartsch commented on patch set 1 09/22/23, 07:39
ErrorHandler.php:141ReplySince access to $GLOBALS['TYPO3_REQUEST'] is already done in getFormattedLogMessage(), I personally would be fine to also use it here. However, we should add a separate method "getRequest(): ServerRequestInterface" to encapsulate the usage of this "API". -
Rémy DANIEL commented on patch set 1 09/29/23, 08:45
ErrorHandler.php:141ReplyTests will need adjustments (a fake TYPO3_REQUEST needs to be set instead of TYPO3_REQUEST_URL env). Please let me know what method is preferable. The initial idea is just to align the log of the request url ErrorHandler and ExceptionHandler. -
Sybille Peters commented on patch set 1 CR +1 10/27/23, 06:09
ErrorHandler.php:141Reply Unresolved+1 for patch but looks like it is stuck. I also think this would be useful to always have the URLs in the logs, not just for exceptions. (Used a custom FileWriter to add it a while ago as a work-around). Will ask in typo3-cms-coredev Slack about recommended way to get the request URL. -
Benni Mack marked it work in progress 03/21/25, 14:56
Unresolved