Review main Merged

78025[BUGFIX] Allow sites with only digit numbers as identifier

Christian Eßl CR +2 V +2 Easy +2 −0 updated 03/10/23, 13:01

Commit message

Fix a missing type cast, where on creating a site with only
a digit number as identifier, both the backend and frontend
would throw a type error.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2431

Show 56 earlier messages
  1. Christian Eßl uploaded patch set 1 03/04/23, 12:27

  2. core-ci voted on patch set 1 V +1 03/04/23, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38437

  3. Oli Bartsch commented on patch set 1 03/04/23, 22:18

    SiteConfiguration.php:153

    We might want a string here as well? I suggest overwriting $identifier with the type casted version in the foreach scope: $identifier = (string)$identifier;
  4. Christian Eßl uploaded patch set 2 V +1 03/06/23, 15:40

  5. Christian Eßl commented on patch set 2 03/06/23, 15:41

    SiteConfiguration.php:153 Reply

    Done
  6. Oliver Klee voted on patch set 2 CR +1 03/06/23, 15:43

  1. Oli Bartsch voted on patch set 2 V +1 CR +1 03/06/23, 15:50

  2. Nikita Hovratov commented on patch set 2 CR -1 03/06/23, 16:07

    Releases missing in commit message. Is this also for v11?
  3. Oliver Klee voted on patch set 2 CR 0 03/06/23, 16:09

  4. Christian Eßl updated the commit message in patch set 3 CR +1 V +1 03/06/23, 16:17

  5. Christian Eßl commented on patch set 3 03/06/23, 16:19

    Reply

    Oops, fixed. No, just main.
  6. core-ci voted on patch set 2 V -1 03/06/23, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38551

  7. core-ci voted on patch set 3 V -1 03/06/23, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38552

  8. core-ci commented on patch set 3 03/06/23, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38552

  9. Nikita Hovratov rebased onto patch set 4 V -1 03/06/23, 17:43

  10. core-ci voted on patch set 4 V +1 03/06/23, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38562

  11. Georg Ringer commented on patch set 4 V +1 CR +1 03/07/23, 12:25

    also confirmed that not needed in v11
  12. Oliver Klee voted on patch set 4 CR +1 03/07/23, 12:28

  13. Markus Klein commented on patch set 4 03/08/23, 21:10

    I suggest adding a comment why this cast is necessary. This is probably not obvious when reading this code again in 5 months.
  14. Christian Eßl uploaded patch set 5 CR +1 V +1 03/09/23, 17:36

  15. core-ci voted on patch set 5 V +1 03/09/23, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38713

  16. Georg Ringer voted on patch set 5 V +1 CR +1 03/09/23, 18:01

  17. Jörg Bösche voted on patch set 5 CR +1 03/10/23, 07:25

  18. Markus Klein commented on patch set 6 CR +1 V +1 03/10/23, 08:12

    Published edit on patch set 5.
  19. Markus Klein commented on patch set 6 03/10/23, 08:13

    should go into v11 too?
  20. core-ci voted on patch set 6 V +1 03/10/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38754

  21. Christian Eßl commented on patch set 6 03/10/23, 09:03

    Reply

    only affects the new "SiteConfiguration" class in v12.
  22. Benni Mack voted on patch set 6 CR +1 03/10/23, 09:35

  23. Markus Klein voted on patch set 6 V +1 CR +1 03/10/23, 12:46

  24. Benni Mack voted on patch set 6 V +2 CR +2 03/10/23, 13:00

  25. Benni Mack merged patch set 7 03/10/23, 13:01