78025[BUGFIX] Allow sites with only digit numbers as identifier
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2431
Show 56 earlier messages
-
Christian Eßl uploaded patch set 1 03/04/23, 12:27
-
core-ci voted on patch set 1 V +1 03/04/23, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38437
-
Oli Bartsch commented on patch set 1 03/04/23, 22:18
-
Christian Eßl uploaded patch set 2
V +103/06/23, 15:40 -
Christian Eßl commented on patch set 2 03/06/23, 15:41
SiteConfiguration.php:153ReplyDone -
Oliver Klee voted on patch set 2 CR +1 03/06/23, 15:43
-
Oli Bartsch voted on patch set 2 V +1 CR +1 03/06/23, 15:50
-
Nikita Hovratov commented on patch set 2 CR -1 03/06/23, 16:07
Releases missing in commit message. Is this also for v11? -
Oliver Klee voted on patch set 2 CR 0 03/06/23, 16:09
-
Christian Eßl updated the commit message in patch set 3
CR +1V +103/06/23, 16:17 -
Christian Eßl commented on patch set 3 03/06/23, 16:19
Reply
Oops, fixed. No, just main. -
core-ci voted on patch set 2 V -1 03/06/23, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38551
-
core-ci voted on patch set 3 V -1 03/06/23, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38552
-
core-ci commented on patch set 3 03/06/23, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38552
-
Nikita Hovratov rebased onto patch set 4
V -103/06/23, 17:43 -
core-ci voted on patch set 4 V +1 03/06/23, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38562
-
Georg Ringer commented on patch set 4 V +1 CR +1 03/07/23, 12:25
also confirmed that not needed in v11 -
Oliver Klee voted on patch set 4 CR +1 03/07/23, 12:28
-
Markus Klein commented on patch set 4 03/08/23, 21:10
I suggest adding a comment why this cast is necessary. This is probably not obvious when reading this code again in 5 months. -
Christian Eßl uploaded patch set 5
CR +1V +103/09/23, 17:36 -
core-ci voted on patch set 5 V +1 03/09/23, 17:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38713
-
Georg Ringer voted on patch set 5 V +1 CR +1 03/09/23, 18:01
-
Jörg Bösche voted on patch set 5 CR +1 03/10/23, 07:25
-
Markus Klein commented on patch set 6
CR +1V +103/10/23, 08:12Published edit on patch set 5. -
Markus Klein commented on patch set 6 03/10/23, 08:13
should go into v11 too? -
core-ci voted on patch set 6 V +1 03/10/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38754
-
Christian Eßl commented on patch set 6 03/10/23, 09:03
Reply
only affects the new "SiteConfiguration" class in v12. -
Benni Mack voted on patch set 6 CR +1 03/10/23, 09:35
-
Markus Klein voted on patch set 6 V +1 CR +1 03/10/23, 12:46
-
Benni Mack voted on patch set 6 V +2 CR +2 03/10/23, 13:00
-
Benni Mack merged patch set 7 03/10/23, 13:01
SiteConfiguration.php:153