Review main Merged

78028[TASK] Switch to custom build docker-dind image

Stefan Bürk CR +2 V +2 Easy +7 −2 updated 03/05/23, 01:58

Commit message

Due a regression since GitLab runner 15.1,we cannot
use the official docker dind image to raise runner
version to keep up with the TYPO3 gitlab instance.

Because of other issues, using a custom docker dind
image with changed expose port for the healthcheck
to work around that issue is needed.

See: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29130

After Gitlab has released a proper fix for this,
this should be reverted and the official docker
dind image used again.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1626

Show 1 earlier messages
  1. Stefan Bürk uploaded patch set 1 03/04/23, 14:28

  1. core-ci voted on patch set 1 V -1 03/04/23, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38442

  2. core-ci commented on patch set 1 03/04/23, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38442

  3. Stefan Bürk uploaded patch set 2 03/04/23, 15:36

    Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE")
  4. Stefan Bürk updated the commit message in patch set 3 V -1 03/04/23, 15:36

  5. core-ci voted on patch set 2 V -1 03/04/23, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38445

  6. core-ci voted on patch set 3 V -1 03/04/23, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38446

  7. Stefan Bürk updated the commit message in patch set 4 V -1 03/04/23, 17:05

  8. Stefan Bürk updated the commit message in patch set 5 03/04/23, 17:31

  9. Stefan Bürk updated the commit message in patch set 6 03/04/23, 17:52

  10. Stefan Bürk updated the commit message in patch set 7 03/04/23, 18:07

  11. core-ci voted on patch set 7 V -1 03/04/23, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38451

  12. Stefan Bürk uploaded patch set 8 V -1 03/04/23, 23:25

  13. core-ci voted on patch set 8 V -1 03/04/23, 23:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38460

  14. Stefan Bürk updated the commit message in patch set 9 V -1 03/04/23, 23:27

  15. Stefan Bürk uploaded patch set 10 03/04/23, 23:29

  16. core-ci voted on patch set 9 V -1 03/04/23, 23:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38461

  17. core-ci voted on patch set 10 V -1 03/04/23, 23:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38462

  18. Stefan Bürk updated the commit message in patch set 11 V -1 03/05/23, 00:23

  19. Stefan Bürk uploaded patch set 12 03/05/23, 00:37

  20. Stefan Bürk uploaded patch set 13 03/05/23, 00:53

  21. core-ci voted on patch set 12 V +1 03/05/23, 00:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38464

  22. core-ci voted on patch set 13 V +1 03/05/23, 01:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38465

  23. Stefan Bürk commented on patch set 13 03/05/23, 01:56

    Bending the rules and merging this without votes to get core ci working again for all branches.
  24. Stefan Bürk voted on patch set 13 V +2 CR +2 03/05/23, 01:58

  25. Stefan Bürk merged patch set 14 03/05/23, 01:58