78032[BUGFIX] Fix exception in view module for missing site configuration
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Markus Klein +1
-
Verified V +2 Done
- Oli Bartsch +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1115
-
Christian Eßl uploaded patch set 1 03/06/23, 08:11
-
core-ci voted on patch set 1 V -1 03/06/23, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38513
-
Christian Eßl rebased onto patch set 2
V -103/07/23, 20:30 -
core-ci voted on patch set 2 V +1 03/07/23, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38628
-
Oliver Klee commented on patch set 2 03/07/23, 22:33
The commit message title is too long. (As a rule of thumb: If it linebreaks in Gerrit, it's too long.) My suggestion: [BUGFIX] Fix exception in view module for missing site configurationViewModuleController.php:85Let's make this more explicit: ``` if ($previewLanguages !== [] && … ``` -
Christian Eßl uploaded patch set 3
V +103/08/23, 07:50 -
core-ci voted on patch set 3 V +1 03/08/23, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38640
-
Oliver Klee commented on patch set 3 03/08/23, 09:26
Reply
DoneViewModuleController.php:85ReplyDone -
Markus Klein commented on patch set 3 03/08/23, 21:08
"expecting" is probably what you meant, right? -
Christian Eßl updated the commit message in patch set 4
V +103/09/23, 17:30 -
Christian Eßl commented on patch set 4 03/09/23, 17:31
Reply
Thanks. I always write expecting wrong, because I think about exceptions... -
core-ci voted on patch set 4 V +1 03/09/23, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38712
-
Markus Klein voted on patch set 4 V +1 CR +1 03/10/23, 08:10
-
Oli Bartsch voted on patch set 4 V +2 CR +2 03/14/23, 14:25
-
Oli Bartsch merged patch set 5 03/14/23, 14:26