Review main Merged

78032[BUGFIX] Fix exception in view module for missing site configuration

Christian Eßl CR +2 V +2 Easy +2 −1 updated 03/14/23, 14:26

Commit message

When opening a page in the view module, that belongs to a page
tree with no valid site configuration, an exception was thrown,
because the ModuleData clean-method was expecting at least one
item in the language array.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Christian Eßl uploaded patch set 1 03/06/23, 08:11

  2. core-ci voted on patch set 1 V -1 03/06/23, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38513

  3. Christian Eßl rebased onto patch set 2 V -1 03/07/23, 20:30

  4. core-ci voted on patch set 2 V +1 03/07/23, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38628

  5. Oliver Klee commented on patch set 2 03/07/23, 22:33

    The commit message title is too long. (As a rule of thumb: If it linebreaks in Gerrit, it's too long.) My suggestion: [BUGFIX] Fix exception in view module for missing site configuration

    ViewModuleController.php:85

    Let's make this more explicit: ``` if ($previewLanguages !== [] && … ```
  6. Christian Eßl uploaded patch set 3 V +1 03/08/23, 07:50

  7. core-ci voted on patch set 3 V +1 03/08/23, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38640

  8. Oliver Klee commented on patch set 3 03/08/23, 09:26

    Reply

    Done

    ViewModuleController.php:85 Reply

    Done
  9. Markus Klein commented on patch set 3 03/08/23, 21:08

    "expecting" is probably what you meant, right?
  10. Christian Eßl updated the commit message in patch set 4 V +1 03/09/23, 17:30

  11. Christian Eßl commented on patch set 4 03/09/23, 17:31

    Reply

    Thanks. I always write expecting wrong, because I think about exceptions...
  12. core-ci voted on patch set 4 V +1 03/09/23, 17:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38712

  13. Markus Klein voted on patch set 4 V +1 CR +1 03/10/23, 08:10

  14. Oli Bartsch voted on patch set 4 V +2 CR +2 03/14/23, 14:25

  15. Oli Bartsch merged patch set 5 03/14/23, 14:26