Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
78036[BUGFIX] Stabilize parameter handling
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/78036/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/78036/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Oliver Hader -2
-
Verified V 0 Needs a vote
Issues 1
Files 1
Review log 810
-
Marc Willmann uploaded patch set 1 03/06/23, 13:22
-
Marc Willmann uploaded patch set 2 03/06/23, 13:26
-
core-ci voted on patch set 1 V -1 03/06/23, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38547
-
core-ci voted on patch set 2 V -1 03/06/23, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38548
-
Oliver Hader commented on patch set 2 CR -2 03/24/23, 08:41
Can provide a realistic example to reproduce the behavior you're trying to solve?VariableProcessor.php:63Unresolvedmd5 hashes are used internally - Symfony Routing does not support variables longer than 32 characters. That's the reason for having it. Please have a look to VariableProcessorTest to get an idea what is involved here. -
Benni Mack updated the commit message in patch set 3
V -105/03/23, 09:40Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Benni Mack updated the commit message in patch set 4 10/18/24, 14:06
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benni Mack marked it work in progress 04/11/25, 21:10
-
Benni Mack commented on patch set 4 04/11/25, 21:11
marking this as WIP, as we lack of feedback - @mw@f7.de can you share some? -
Aurélien Jean commented on patch set 4 06/13/25, 15:36
Reply
I had the same problem, and tested the bugfix, and it's working for me !