Review main Merged

78040[TASK] Cleanup eslint configuration

Benjamin Kott CR +2 V +2 Nightmare +2892 −2912 updated 03/09/23, 11:27

Commit message

We renamed the eslint configuration to follow the recommended standards
so developers IDEs will pick up the configuration more easily.

The ruleset was adapted to follow a wider range of recommendations.
- eslint:recommended
- @typescript-eslint/recommended
- lit/recommended
- wc/recommended

In addition we now also force more kinds of spacing rules to avoid
IDEs having different opinions on how to format for example includes.

The only recommendation we don't want to follow is
- @typescript-eslint/no-inferrable-types.
We don't want to disallow being explicit.

Instead of turning off rules we cannot fully fulfill as of now, we are
now changing the configuration to warning. This will help developers
spotting mistakes more easy when writing code.

Rules that are currently in "warn" mode:
- @typescript-eslint/ban-types
- @typescript-eslint/no-explicit-any
- @typescript-eslint/no-this-alias

To only check for errors run in the Build directory:
- npx eslint ./Sources/TypeScript/ --quiet

We are removing the custom member ordering and preferring the default.
@typescript-eslint/member-ordering

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 399

Show 379 more files