Review main Merged

78041[BUGFIX] Fix PHP 8 warnings in GifBuilder

Thomas Hohn CR +2 V +2 Easy +4 −4 updated 03/14/23, 14:35

Commit message

Added some guards, isset(), to ensure that array keys
that aren't defined are accessed and throws PHP warnings.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Thomas Hohn uploaded patch set 1 03/06/23, 17:59

  2. Oliver Klee voted on patch set 1 CR +1 03/06/23, 18:05

  3. core-ci voted on patch set 1 V +1 03/06/23, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38563

  4. Benni Mack voted on patch set 1 V +1 CR +1 03/08/23, 08:14

  5. Jörg Bösche voted on patch set 1 CR +1 03/10/23, 07:30

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 03/14/23, 14:35

  7. Christian Kuhn merged patch set 2 03/14/23, 14:35