Review main Abandoned

78044[BUGFIX] Improve performance of PagesXmlSitemapDataProvider

Christian Eßl CR 0 V 0 Normal +81 −37 updated 03/28/25, 13:36

Commit message

Improve the performance of the page sitemap generation by:
- Directly using the site's router to save many db requests. Otherwise,
  when using $cObj->createUrl(), TYPO3 would have to recursively fetch
  the rootline for each single page in the sitemap, which leads to a
  huge overhead on large websites.
- Fetching only fields required for sitemap generation.
- Rewriting the logic for recursively fetching the pages. Using
  $pageRepository->getDescendantPageIdsRecursive() here is not a good
  idea, because this method automatically resolves the target pages of
  mount points internally and then only returns a list of all page ids.
  After this step, it is never known, if a resolved page id came from a
  mount point and we would be missing crucial information for correctly
  linking a mounted page. -> This is linked to another issue (#100102),
  where uris to mount pages have never worked in
  PagesXmlSitemapDataProvider. This will be fixed in a later patch.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 1

Review log 2437

Show 712 earlier messages
  1. Christian Eßl uploaded patch set 1 03/07/23, 07:58

  2. Christian Eßl updated the commit message in patch set 2 03/07/23, 08:02

  3. core-ci voted on patch set 1 V -1 03/07/23, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38578

  4. core-ci voted on patch set 2 V -1 03/07/23, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38579

  5. Christian Eßl rebased onto patch set 3 V -1 03/07/23, 10:36

  6. core-ci voted on patch set 3 V -1 03/07/23, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38589

  7. Oliver Klee commented on patch set 3 03/07/23, 12:04

    I'd really prefer to have this in a separate change. Reading only the title of the commit message (as it would appear in the changelog), it is not clear at all that this performance improvement also fixes some broken behavior. Also, is there any way we could cover this fix (the behavior fix, not the performance fix) with a regression test?
  8. Christian Eßl uploaded patch set 4 V -1 03/07/23, 13:15

  9. Christian Eßl commented on patch set 4 03/07/23, 13:17

    Reply

    Ok, I'll remove the mount point fix for now and handle this issue later with a test, after this has been merged.
  10. Christian Eßl rebased onto patch set 5 03/07/23, 13:18

  11. core-ci voted on patch set 4 V -1 03/07/23, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38599

  12. core-ci voted on patch set 5 V -1 03/07/23, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38600

  1. Christian Eßl uploaded patch set 6 V -1 03/07/23, 13:47

  2. core-ci voted on patch set 6 V -1 03/07/23, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38606

  3. Christian Eßl uploaded patch set 7 V -1 03/07/23, 16:07

  4. core-ci voted on patch set 7 V -1 03/07/23, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38613

  5. Christian Eßl uploaded patch set 8 V -1 03/07/23, 16:38

  6. core-ci voted on patch set 8 V +1 03/07/23, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38616

  7. Christian Eßl commented on patch set 8 03/08/23, 16:26

    For clarification: I did not use the previously used $pageRepository->getDescendantPageIdsRecursive() in the changes, because this method internally always automatically resolves mount points and then only returns the pageIds as result (in case of a mount point, the id that the mount page is pointing to). After this step, just from the page ids, we would NEVER know how a mounted page should actually be linked in the sitemap. Links to mounted pages may have never been working in PagesXmlSitemapDataProvider, but I will fix this in a later bugfix patch.
  8. Kevin Appelt commented on patch set 8 03/09/23, 06:47

    Could you please take another look at the commit message? The sentence seems to be either missing some information or the "by" seems unnecessary. "Improve the performance of the page sitemap generation by and fix issues with wrong mounted page urls."
  9. Christian Eßl updated the commit message in patch set 9 V +1 03/09/23, 18:25

  10. core-ci voted on patch set 9 V +1 03/09/23, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38714

  11. Benni Mack updated the commit message in patch set 10 V +1 05/03/23, 09:34

  12. core-ci voted on patch set 10 V +1 05/03/23, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41431

  13. Benni Mack rebased onto patch set 11 V +1 07/06/23, 17:00

  14. core-ci voted on patch set 11 V +1 07/06/23, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43779

  15. Benni Mack commented on patch set 11 07/07/23, 13:43

    this solution does not exclude things like spacers, and backend user section (incl. subpages) by default. Also, I don't know if we have extendToSubpages covered with this solution then?
  16. Benni Mack voted on patch set 11 CR -1 07/07/23, 13:43

  17. Oliver Klee commented on patch set 11 07/16/23, 08:34

    How should we continue here?
  18. Oliver Klee wrote 08/25/24, 10:13

    Removed cc Oliver Klee.
  19. Benni Mack updated the commit message in patch set 12 CR -1 V +1 10/18/24, 13:46

  20. Simon Schaufelberger uploaded patch set 13 12/06/24, 12:42

  21. core-ci voted on patch set 13 V -1 12/06/24, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70705

  22. Simon Schaufelberger uploaded patch set 14 V -1 12/06/24, 12:49

  23. core-ci voted on patch set 14 V -1 12/06/24, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70707

  24. Simon Schaufelberger commented on patch set 14 12/06/24, 12:56

    Unresolved

    @indy.essl@gmail.com can you please have a look at the broken tests?
  25. Benni Mack abandoned the change 03/28/25, 13:36

    abandoning this change, as no progress happened after 1.5 years of asking for feedback. I will continue with this one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87868