78045[TASK] Improve performance of IRRE records in Backend Forms
Commit message
Review
-
Code review CR -1
- Christian Kuhn -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php3+31 −0
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php6+1 −13
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php3+3 −7
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+1 −7
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+0 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractDatabaseRecordProvider.php6+8 −12
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php4+25 −16
Review log 2332
Show 57 earlier messages
-
Christian Eßl uploaded patch set 1 03/07/23, 12:23
-
core-ci voted on patch set 1 V -1 03/07/23, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38595
-
Christian Eßl uploaded patch set 2
V -103/07/23, 13:11 -
Oliver Klee commented on patch set 2 03/07/23, 13:14
InlineRecordContainer.php:556At a first glance, this looks like duplicated code to the other class. Can we avoid the duplication? -
core-ci voted on patch set 2 V +1 03/07/23, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38598
-
Christian Eßl uploaded patch set 3
V +103/07/23, 13:23 -
Christian Eßl uploaded patch set 4 03/07/23, 13:25
-
Christian Eßl commented on patch set 2 03/07/23, 13:25
ack -
core-ci voted on patch set 3 V -1 03/07/23, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38601
-
core-ci voted on patch set 4 V +1 03/07/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38602
-
Georg Ringer commented on patch set 4 03/08/23, 19:35
FileReferenceContainer.php:544this comment belongs to the methodFileReferenceContainer.php:546this is not a hash but now an $identifierInlineRecordContainer.php:556Replywe could move it to the abstractcontainerAbstractDatabaseRecordProvider.php:73remove comment, imo not neededAbstractDatabaseRecordProvider.php:75do we need the hash? can be avoided i guessDatabasePageLanguageOverlayRows.php:54remove commentDatabasePageLanguageOverlayRows.php:56$identifier -
Christian Eßl uploaded patch set 5
V +103/09/23, 18:31 -
Christian Eßl commented on patch set 4 03/09/23, 18:31
FileReferenceContainer.php:544ReplyDoneFileReferenceContainer.php:546ReplyDoneInlineRecordContainer.php:556ReplyDoneAbstractDatabaseRecordProvider.php:73ReplyDoneAbstractDatabaseRecordProvider.php:75ReplyDoneDatabasePageLanguageOverlayRows.php:54ReplyDoneDatabasePageLanguageOverlayRows.php:56ReplyDone -
core-ci voted on patch set 5 V -1 03/09/23, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38715
-
Christian Eßl uploaded patch set 6
V -103/09/23, 19:58 -
core-ci voted on patch set 6 V -1 03/09/23, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38718
-
Christian Eßl uploaded patch set 7
V -103/10/23, 05:22 -
core-ci voted on patch set 7 V +1 03/10/23, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38726
-
Benni Mack commented on patch set 7 03/10/23, 08:08
AbstractDatabaseRecordProvider.php:73I wonder why we just don't use BackendUtility::getRecord and wrap this into a runtimeCache? -
Christian Eßl uploaded patch set 8
V +103/10/23, 11:19 -
Christian Eßl commented on patch set 7 03/10/23, 11:21
AbstractDatabaseRecordProvider.php:73ReplyAck -
core-ci voted on patch set 8 V +1 03/10/23, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38764
-
Oliver Klee commented on patch set 8 03/10/23, 12:05
FileReferenceContainer.php:546ReplyDone -
Oliver Klee commented on patch set 8 03/10/23, 15:53
AbstractContainer.php:142I'd like to propose we make the new methods `@internal` so we can refactor or delete them later at will. -
Christian Eßl uploaded patch set 9
V +103/11/23, 15:44 -
Christian Eßl commented on patch set 8 03/11/23, 15:45
AbstractContainer.php:142ReplyDone -
core-ci voted on patch set 9 V +1 03/11/23, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38798
-
Christian Kuhn commented on patch set 9 CR -1 03/21/23, 15:03
in general, i get the idea on what you're doing here and think we could very well improve the code to increase performance. i have one remark that may/should be refactored from my point-of-view, though. would you like to have a look?AbstractContainer.php:144Unresolvedthis is the part of the patch that i don't like much: the container and element classes should essentially work on data that has been created by the provider classes, only. instead of abstracting the permission stuff into the container abstract, they should be wired into the data array somehow. i could imagine we add this to the pages related data as sub-key, or have an own key within the data array or something like that. this may also remove the need for the runtime cache entirely. do you think it's possible to refactor the patch in this regard somehow? at the moment, i don't have "the solution" at hand, but only the general direction. if you're stuck, we could have a chat on this to see if we can move this patch forward together. please ping me if so, i'd need some time to look up more details. -
Oliver Klee commented on patch set 9 07/16/23, 08:35
How should we continue here? -
Oliver Klee wrote 08/25/24, 10:13
Removed cc Oliver Klee. -
Benni Mack marked it work in progress 03/06/25, 18:53
-
Benni Mack abandoned the change 11/12/26, 18:59
abandoning this one (it's stale) in favor of this approach, which hits the spot that Christian (Kuhn) mentioned: https://review.typo3.org/c/Packages/TYPO3.CMS/+/97584
FileReferenceContainer.php:546