Review main Abandoned

78050[BUGFIX] Fix type error in UnableToLinkException->getLinkText

Thomas Hohn CR 0 V 0 Easy +1 −1 updated 03/07/23, 21:00

Commit message

The type hint indicates, that $linkText should be of type string.
However this is not always the case in TYPO3 v11, it can contain
an instance LinkResult.
The code has been heavily refactored in TYPO3 v12 and since the
potential code has been removed from ContentObjectRenderer this
fix is to be considered temporarily.
In TYPO3 v13 the signature of the constructor should be changed
to be strict typed, and only accept string as a valid type for
$linkText.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 2

  1. Thomas Hohn uploaded patch set 1 03/07/23, 20:56

  2. Thomas Hohn abandoned the change 03/07/23, 21:00

    Faulty commit