Review 11.5 Merged

78057[BUGFIX] Ensure scaled image size width/height are integers

Georg Ringer CR +2 V +2 Easy +12 −12 updated 03/16/23, 10:59

Commit message

Given the input width/heigth, getImageScale can return either int or float, depending of the calculated sizes.

This can triggers strict type warnings in calling code,
if width/heigth are expected to be integers.

In order to fix this, returned width/height are now always integers.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 03/16/23, 06:57

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/16/23, 07:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39034

  3. Georg Ringer voted on patch set 1 V +2 CR +2 03/16/23, 10:59

  4. Georg Ringer merged patch set 2 03/16/23, 10:59