78072[TASK] Add todo for strictly typing class UnableToLinkException
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1216
-
Thomas Hohn uploaded patch set 1 03/08/23, 09:05
-
core-ci voted on patch set 1 V +1 03/08/23, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38646
-
Benni Mack commented on patch set 1 03/08/23, 09:52
-
Thomas Hohn commented on patch set 1 03/08/23, 10:40
UnableToLinkException.php:30ReplyAck -
Thomas Hohn uploaded patch set 2
V +103/08/23, 10:42 -
core-ci voted on patch set 2 V +1 03/08/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38650
-
Oliver Klee commented on patch set 2 03/08/23, 11:58
The subject now is misleading, as it implies that this change adds the strict typing (which it doesn't). My suggestion: [TASK] Add todo for strict typing UnableToLinkException constructor (I've omitted the "the" to keep the line short.) What do you think? -
Thomas Hohn updated the commit message in patch set 3
V +103/08/23, 12:16 -
Thomas Hohn commented on patch set 3 03/08/23, 12:16
Reply
I changed it to: [TASK] Added todo for strictly typing class UnableToLinkException Since it's both the constructor and the class variable that are affected -
Oliver Klee updated the commit message in patch set 4 03/08/23, 12:18
-
Oliver Klee voted on patch set 4 V +1 CR +1 03/08/23, 12:19
-
core-ci voted on patch set 3 V +1 03/08/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38652
-
core-ci voted on patch set 4 V +1 03/08/23, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38653
-
Georg Ringer voted on patch set 4 V +1 CR +1 03/08/23, 14:21
-
Christian Kuhn voted on patch set 4 V +2 CR +2 03/14/23, 13:50
-
Christian Kuhn merged patch set 5 03/14/23, 13:50
UnableToLinkException.php:30