7808[BUGFIX] Shortcut page does not keep 'type' parameter
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Wouter Wolters +1
- Steffen Ritter +1
-
Verified V +2
- Oliver Hader +2
Files 1
Review log 7
-
Oliver Hader commented on patch set 1 03/13/12, 07:09
I would prefer that you didn't submit this "My vote" on this was given automatically to summarize previous votes (see accordant post in v4 list). This change only works for the root page and I don't think it's the right approach. Using "config.linkVars = type" is the correct one since you probably want to stay on that type...class.tslib_fe.php:2690could have used $this->type instead... but whatever... -
Oliver Hader commented on patch set 1 V 0 1 comment 03/13/12, 07:09
by team member; Looks good to me, approved -
Steffen Ritter commented on patch set 1 03/13/12, 07:09
stop, now I get what you mean... think you may be right... But probably you wann call one specific page with one specific page-type. Without wanting that the type is kept in linking (f.e. ajax content). This could happen by just adding "another type" to the URL of the page you currently have opened. So if the URL you are requesting is an shortcut by accident, then you'll retrieve the output of the correct page - but the type for this specific request has been omitted. -
Steffen Ritter commented on patch set 1 03/13/12, 07:09
Hi Olly, I do not think this is meant to to be sth. for type keeping. And I even coul d not imagine "how" this should work even with type parameter... The problem is, that if a shortcut page redirects, the currently hand over type-parameter ist omitted - regardless of the tsconfig or url parameter. And with that, the type just gets lost -
Steffen Ritter commented on patch set 1 03/13/12, 07:09
Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 1 03/13/12, 07:09
Looks good to me, but someone else must approve -
Oliver Hader merged patch set 1 03/13/12, 07:09