78080[BUGFIX] Fix incorrect type annotation for GU::makeInstance
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Thomas Hohn +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Thomas Hohn +1
- Alexander Schnitzler +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Oliver Klee uploaded patch set 1 03/09/23, 09:58
-
Thomas Hohn voted on patch set 1 CR +1 03/09/23, 09:59
-
Alexander Schnitzler voted on patch set 1 V +1 CR +1 03/09/23, 10:02
-
Thomas Hohn voted on patch set 1 V +1 03/09/23, 10:03
-
core-ci voted on patch set 1 V +1 03/09/23, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38687
-
Nikita Hovratov commented on patch set 1 03/09/23, 11:33
Is this critical for 10.4? Otherwise I would suggest only to backport to 11.5. -
Oliver Klee commented on patch set 1 03/09/23, 11:45
Reply
It will really help extension authors get rid of PHPStan warnings in their code that calls GU::makeInstance(). So it's not critical, but extremely helpful. -
Nikita Hovratov commented on patch set 1 V +1 CR +1 03/09/23, 12:25
Reply
Ack -
Nikita Hovratov voted on patch set 1 V +2 CR +2 03/09/23, 13:04
-
Nikita Hovratov merged patch set 2 03/09/23, 13:04