Review 10.4 Merged

78082[BUGFIX] Fix incorrect type annotation for GU::makeInstance

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 03/09/23, 16:35

Commit message

For variable arguments, the type annotation needs to match the
type of the single arguments, not an array of the single arguments.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 1020

  1. Nikita Hovratov uploaded patch set 1 03/09/23, 12:34

  2. Oliver Klee voted on patch set 1 CR +1 03/09/23, 12:44

  3. core-ci voted on patch set 1 V -1 03/09/23, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38698

  4. core-ci commented on patch set 1 03/09/23, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38698

  5. core-ci commented on patch set 1 03/09/23, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38698

  6. Nikita Hovratov updated the commit message in patch set 2 CR +1 V -1 03/09/23, 13:26

  7. core-ci voted on patch set 2 V -1 03/09/23, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700

  8. core-ci commented on patch set 2 03/09/23, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700

  9. core-ci commented on patch set 2 03/09/23, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700

  10. core-ci commented on patch set 2 03/09/23, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700

  11. Oliver Klee commented on patch set 2 03/09/23, 14:55

    I have no idea why some of the acceptance tests are failing. (And I don't know how that could be related to a PHPDoc annotation change in any way.) :-(
  12. core-ci commented on patch set 2 03/09/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700

  13. Nikita Hovratov uploaded patch set 3 V -1 03/09/23, 15:05

  14. Nikita Hovratov commented on patch set 3 03/09/23, 15:06

    Reply

    It has to be unrelated, but to be completely sure I reverted the patch, let's see.
  15. core-ci voted on patch set 3 V -1 03/09/23, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38701

  16. Nikita Hovratov uploaded patch set 4 V -1 03/09/23, 16:26

  17. Nikita Hovratov commented on patch set 4 03/09/23, 16:26

    Reply

    I didn't rebase to the latest patch.. now it should go green.
  18. core-ci voted on patch set 4 V +1 03/09/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38703

  19. Nikita Hovratov voted on patch set 4 V +2 CR +2 03/09/23, 16:35

  20. Nikita Hovratov merged patch set 5 03/09/23, 16:35