78082[BUGFIX] Fix incorrect type annotation for GU::makeInstance
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
-
Verified V +2 Done
- Nikita Hovratov +2
- core-ci +1 CI
Issues 1
Files 1
Review log 1020
-
Nikita Hovratov uploaded patch set 1 03/09/23, 12:34
-
Oliver Klee voted on patch set 1 CR +1 03/09/23, 12:44
-
core-ci voted on patch set 1 V -1 03/09/23, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38698
-
core-ci commented on patch set 1 03/09/23, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38698
-
core-ci commented on patch set 1 03/09/23, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38698
-
Nikita Hovratov updated the commit message in patch set 2
CR +1V -103/09/23, 13:26 -
core-ci voted on patch set 2 V -1 03/09/23, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700
-
core-ci commented on patch set 2 03/09/23, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700
-
core-ci commented on patch set 2 03/09/23, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700
-
core-ci commented on patch set 2 03/09/23, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700
-
Oliver Klee commented on patch set 2 03/09/23, 14:55
I have no idea why some of the acceptance tests are failing. (And I don't know how that could be related to a PHPDoc annotation change in any way.) :-( -
core-ci commented on patch set 2 03/09/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38700
-
Nikita Hovratov uploaded patch set 3
V -103/09/23, 15:05 -
Nikita Hovratov commented on patch set 3 03/09/23, 15:06
Reply
It has to be unrelated, but to be completely sure I reverted the patch, let's see. -
core-ci voted on patch set 3 V -1 03/09/23, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38701
-
Nikita Hovratov uploaded patch set 4
V -103/09/23, 16:26 -
Nikita Hovratov commented on patch set 4 03/09/23, 16:26
Reply
I didn't rebase to the latest patch.. now it should go green. -
core-ci voted on patch set 4 V +1 03/09/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38703
-
Nikita Hovratov voted on patch set 4 V +2 CR +2 03/09/23, 16:35
-
Nikita Hovratov merged patch set 5 03/09/23, 16:35