Review main Merged

78084[TASK] Update to PHPStan 1.10.6

Oliver Klee CR +2 V +2 Easy +15 −30 updated 03/09/23, 18:14

Commit message

This version removes some false positives from the baseline.

> composer req --dev phpstan/phpstan:^1.10.6
> composer req --dev phpstan/phpstan-phpunit:^1.3.10
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Oliver Klee uploaded patch set 1 03/09/23, 17:14

  2. Oliver Klee uploaded patch set 2 03/09/23, 17:17

  3. core-ci voted on patch set 1 V +1 03/09/23, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38710

  4. core-ci voted on patch set 2 V +1 03/09/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38711

  5. Georg Ringer voted on patch set 2 V +1 CR +1 03/09/23, 18:01

  6. Alexander Schnitzler voted on patch set 2 V +1 CR +1 03/09/23, 18:09

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 03/09/23, 18:14

  8. Anja Leichsenring merged patch set 3 03/09/23, 18:14