78095[FEATURE] Add commands list/execute for EXT:scheduler
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100143-SchedulerCommandExecuteAndList.rstnew+59 −0
- typo3/sysext/scheduler/Classes/Command/SchedulerExecuteCommand.php9new+165 −0
- typo3/sysext/scheduler/Classes/Command/SchedulerListCommand.php9new+195 −0
- typo3/sysext/scheduler/Classes/Controller/AvailableSchedulerTasksController.php2+3 −30
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+12 −134
- typo3/sysext/scheduler/Classes/Domain/Repository/SchedulerTaskRepository.php+116 −0
- typo3/sysext/scheduler/Classes/Service/TaskService.phpnew+60 −0
- typo3/sysext/scheduler/Configuration/Services.yaml1+14 −0
Review log 2944
Show 1019 earlier messages
-
Jochen Roth uploaded patch set 1 03/11/23, 23:25
-
core-ci voted on patch set 1 V -1 03/12/23, 00:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38811
-
Jochen Roth uploaded patch set 2
V -103/12/23, 17:22 -
core-ci voted on patch set 2 V -1 03/12/23, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38834
-
Jochen Roth uploaded patch set 3
V -103/12/23, 17:44 -
core-ci voted on patch set 3 V -1 03/12/23, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38838
-
Jochen Roth uploaded patch set 4
V -103/12/23, 18:09 -
core-ci voted on patch set 4 V -1 03/12/23, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38841
-
Jochen Roth uploaded patch set 5
V -103/12/23, 18:31 -
core-ci voted on patch set 5 V -1 03/12/23, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38843
-
Jochen Roth uploaded patch set 6
V -103/12/23, 19:02 -
core-ci voted on patch set 6 V +1 03/12/23, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38845
-
Benni Mack uploaded patch set 7
V +103/20/23, 22:20 -
core-ci voted on patch set 7 V +1 03/20/23, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39285
-
Jochen Roth uploaded patch set 8
V +103/22/23, 12:23 -
core-ci voted on patch set 8 V -1 03/22/23, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39381
-
Benni Mack uploaded patch set 9
V -103/22/23, 17:01 -
core-ci voted on patch set 9 V +1 03/22/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39403
-
Benni Mack commented on patch set 10
V +103/22/23, 19:22Published edit on patch set 9.
-
core-ci voted on patch set 10 V +1 03/22/23, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39411
-
Benni Mack voted on patch set 10 V +1 CR +1 03/22/23, 21:23
-
Guido Schmechel commented on patch set 10 03/22/23, 22:49
SchedulerListCommand.php:66Copy/Paste?SchedulerListCommand.php:123Is this still active?SchedulerListCommand.php:169Does it perhaps make sense to display the same columns as in the backend? -
Benni Mack uploaded patch set 11
CR +1V +103/24/23, 11:43 -
core-ci voted on patch set 11 V +1 03/24/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39540
-
Stefan Bürk commented on patch set 11 CR -1 03/24/23, 13:58
on it ...SchedulerExecuteCommand.php:34execute however, I find this class comment completly useless ...SchedulerExecuteCommand.php:51superflous - is set in `Services.yaml` - and wrong (copy&paste) anywaySchedulerListCommand.php:55superflous - is set in `Services.yaml`SchedulerListCommand.php:66Replyack.AvailableSchedulerTasksController.php:42`private` simply to be conform with the other and avoiding "why are they different"Services.yaml:25Yeah - would be weired to have this schedulable ;) -
Stefan Bürk commented on patch set 11 03/24/23, 14:03
SchedulerExecuteCommand.php:91If system has no tasks configured, this will lead to an exception: ``` Choice question must have at least 1 choice available. ``` This should be guarded somehow. -
Stefan Bürk uploaded patch set 12
CR -1V +103/24/23, 15:47 -
Stefan Bürk commented on patch set 11 CR -1 03/24/23, 15:49
SchedulerExecuteCommand.php:34ReplyDoneSchedulerExecuteCommand.php:51ReplyDoneSchedulerExecuteCommand.php:91ReplyDoneSchedulerListCommand.php:55ReplyDoneSchedulerListCommand.php:66ReplyDoneSchedulerListCommand.php:123Replychecked, todo is superflous.SchedulerListCommand.php:169ReplyWould say let's see. console tends to be not so spacefull, and eventally wrapping tables are a nightmare. For now, this is more a current state/monitoring and what happens (active, running, etc).AvailableSchedulerTasksController.php:42ReplyDone -
Stefan Bürk uploaded patch set 13 03/24/23, 15:50
-
core-ci voted on patch set 12 V +1 03/24/23, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39570
-
core-ci voted on patch set 13 V +1 03/24/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39571
-
Stefan Bürk voted on patch set 13 V +1 CR +1 03/24/23, 16:04
-
Nikita Hovratov commented on patch set 13 03/24/23, 16:34
phpstan-baseline.neon:3109Can we prevent this entry? -
Nikita Hovratov commented on patch set 13 CR -1 03/24/23, 16:40
on it -
Nikita Hovratov uploaded patch set 14
CR +1V +103/24/23, 19:39 -
Nikita Hovratov commented on patch set 14 V +1 CR +1 03/24/23, 19:40
phpstan-baseline.neon:3109ReplyDone -
Nikita Hovratov commented on patch set 14 03/24/23, 19:45
SchedulerExecuteCommand.php:91Reason for removal: Validator for a fixed list of choices makes no sense. If the user enters something not in the list, an error will be shown anyway. -
core-ci voted on patch set 14 V +1 03/24/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39588
-
Benni Mack commented on patch set 14 03/24/23, 19:57
SchedulerExecuteCommand.php:57any reason you switch to inject methods? -
Nikita Hovratov uploaded patch set 15
CR +1V +103/24/23, 21:18 -
Nikita Hovratov commented on patch set 15 V +1 CR +1 03/24/23, 21:19
SchedulerExecuteCommand.php:57ReplyNo. -
core-ci voted on patch set 15 V +1 03/24/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39605
-
Stefan Bürk voted on patch set 15 V +2 CR +2 03/24/23, 21:36
-
Stefan Bürk merged patch set 16 03/24/23, 21:36