Review main Merged

78095[FEATURE] Add commands list/execute for EXT:scheduler

Jochen Roth CR +2 V +2 Hard +624 −164 updated 03/24/23, 21:36

Commit message

Currently, it is not possible to get the uid of a given
task via cli.

For ease of use, the command 'scheduler:list' has been
added to list all available tasks or only a given group.

On top of that another command called 'scheduler:execute'
was added which provides a multi-select list where the
user can choose which tasks or grouped tasks to run.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2944

Show 1019 earlier messages
  1. Jochen Roth uploaded patch set 1 03/11/23, 23:25

  2. core-ci voted on patch set 1 V -1 03/12/23, 00:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38811

  3. Jochen Roth uploaded patch set 2 V -1 03/12/23, 17:22

  4. core-ci voted on patch set 2 V -1 03/12/23, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38834

  5. Jochen Roth uploaded patch set 3 V -1 03/12/23, 17:44

  6. core-ci voted on patch set 3 V -1 03/12/23, 17:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38838

  7. Jochen Roth uploaded patch set 4 V -1 03/12/23, 18:09

  8. core-ci voted on patch set 4 V -1 03/12/23, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38841

  9. Jochen Roth uploaded patch set 5 V -1 03/12/23, 18:31

  10. core-ci voted on patch set 5 V -1 03/12/23, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38843

  11. Jochen Roth uploaded patch set 6 V -1 03/12/23, 19:02

  12. core-ci voted on patch set 6 V +1 03/12/23, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38845

  13. Benni Mack uploaded patch set 7 V +1 03/20/23, 22:20

  14. core-ci voted on patch set 7 V +1 03/20/23, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39285

  15. Jochen Roth uploaded patch set 8 V +1 03/22/23, 12:23

  16. core-ci voted on patch set 8 V -1 03/22/23, 13:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39381

  17. Benni Mack uploaded patch set 9 V -1 03/22/23, 17:01

  18. core-ci voted on patch set 9 V +1 03/22/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39403

  19. Benni Mack commented on patch set 10 V +1 03/22/23, 19:22

    Published edit on patch set 9.
  1. core-ci voted on patch set 10 V +1 03/22/23, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39411

  2. Benni Mack voted on patch set 10 V +1 CR +1 03/22/23, 21:23

  3. Guido Schmechel commented on patch set 10 03/22/23, 22:49

    SchedulerListCommand.php:66

    Copy/Paste?

    SchedulerListCommand.php:123

    Is this still active?

    SchedulerListCommand.php:169

    Does it perhaps make sense to display the same columns as in the backend?
  4. Benni Mack uploaded patch set 11 CR +1 V +1 03/24/23, 11:43

  5. core-ci voted on patch set 11 V +1 03/24/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39540

  6. Stefan Bürk commented on patch set 11 CR -1 03/24/23, 13:58

    on it ...

    SchedulerExecuteCommand.php:34

    execute however, I find this class comment completly useless ...

    SchedulerExecuteCommand.php:51

    superflous - is set in `Services.yaml` - and wrong (copy&paste) anyway

    SchedulerListCommand.php:55

    superflous - is set in `Services.yaml`

    SchedulerListCommand.php:66 Reply

    ack.

    AvailableSchedulerTasksController.php:42

    `private` simply to be conform with the other and avoiding "why are they different"

    Services.yaml:25

    Yeah - would be weired to have this schedulable ;)
  7. Stefan Bürk commented on patch set 11 03/24/23, 14:03

    SchedulerExecuteCommand.php:91

    If system has no tasks configured, this will lead to an exception: ``` Choice question must have at least 1 choice available. ``` This should be guarded somehow.
  8. Stefan Bürk uploaded patch set 12 CR -1 V +1 03/24/23, 15:47

  9. Stefan Bürk commented on patch set 11 CR -1 03/24/23, 15:49

    SchedulerExecuteCommand.php:34 Reply

    Done

    SchedulerExecuteCommand.php:51 Reply

    Done

    SchedulerExecuteCommand.php:91 Reply

    Done

    SchedulerListCommand.php:55 Reply

    Done

    SchedulerListCommand.php:66 Reply

    Done

    SchedulerListCommand.php:123 Reply

    checked, todo is superflous.

    SchedulerListCommand.php:169 Reply

    Would say let's see. console tends to be not so spacefull, and eventally wrapping tables are a nightmare. For now, this is more a current state/monitoring and what happens (active, running, etc).

    AvailableSchedulerTasksController.php:42 Reply

    Done
  10. Stefan Bürk uploaded patch set 13 03/24/23, 15:50

  11. core-ci voted on patch set 12 V +1 03/24/23, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39570

  12. core-ci voted on patch set 13 V +1 03/24/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39571

  13. Stefan Bürk voted on patch set 13 V +1 CR +1 03/24/23, 16:04

  14. Nikita Hovratov commented on patch set 13 03/24/23, 16:34

    phpstan-baseline.neon:3109

    Can we prevent this entry?
  15. Nikita Hovratov commented on patch set 13 CR -1 03/24/23, 16:40

    on it
  16. Nikita Hovratov uploaded patch set 14 CR +1 V +1 03/24/23, 19:39

  17. Nikita Hovratov commented on patch set 14 V +1 CR +1 03/24/23, 19:40

    phpstan-baseline.neon:3109 Reply

    Done
  18. Nikita Hovratov commented on patch set 14 03/24/23, 19:45

    SchedulerExecuteCommand.php:91

    Reason for removal: Validator for a fixed list of choices makes no sense. If the user enters something not in the list, an error will be shown anyway.
  19. core-ci voted on patch set 14 V +1 03/24/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39588

  20. Benni Mack commented on patch set 14 03/24/23, 19:57

    SchedulerExecuteCommand.php:57

    any reason you switch to inject methods?
  21. Nikita Hovratov uploaded patch set 15 CR +1 V +1 03/24/23, 21:18

  22. Nikita Hovratov commented on patch set 15 V +1 CR +1 03/24/23, 21:19

    SchedulerExecuteCommand.php:57 Reply

    No.
  23. core-ci voted on patch set 15 V +1 03/24/23, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39605

  24. Stefan Bürk voted on patch set 15 V +2 CR +2 03/24/23, 21:36

  25. Stefan Bürk merged patch set 16 03/24/23, 21:36