Review main Merged

78098[TASK] Make parameter names of GU::revExplode consistent

Oliver Klee CR +2 V +2 Easy +7 −6 updated 03/14/23, 14:06

Commit message

Now the parameter names are consistent with those of the other
explode-related methods.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Oliver Klee uploaded patch set 1 03/12/23, 10:16

  2. core-ci voted on patch set 1 V +1 03/12/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38825

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/12/23, 19:25

  4. Josef Glatz voted on patch set 1 V +1 CR +1 03/13/23, 05:05

  5. Nikita Hovratov commented on patch set 1 V -1 03/13/23, 09:52

    -1 for now, because we didn't agree yet, if changing parameter names is breaking (when using PHP 8 named arguments).
  6. Benni Mack commented on patch set 1 03/13/23, 14:39

    not breaking.
  7. Benni Mack commented on patch set 1 03/13/23, 14:40

    the reasoning is: We did not define this as API in our backwards-compat docs + news, so it's not included.
  8. Nikita Hovratov voted on patch set 1 V 0 03/13/23, 17:33

  9. Benni Mack voted on patch set 1 V +2 CR +2 03/14/23, 14:06

  10. Benni Mack merged patch set 2 03/14/23, 14:06