Review main Merged

78100[TASK] Modernize array function callbacks in Fluid

Oliver Klee CR +2 V +2 Easy +3 −3 updated 03/20/23, 23:03

Commit message

Function callbacks are declared using the new PHP 8.1 feature
"first class callable", which e.g. uses the named `trim(...)`
function symbol, instead of the string `'trim'`.

see https://www.php.net/manual/en/functions.first_class_callable_syntax.php

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Oliver Klee uploaded patch set 1 03/12/23, 10:52

  2. core-ci voted on patch set 1 V +1 03/12/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38827

  3. Torben Hansen voted on patch set 1 V +1 CR +1 03/13/23, 18:17

  4. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 03/14/23, 11:30

  5. core-ci voted on patch set 2 V +1 03/14/23, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38913

  6. Oliver Klee updated the commit message in patch set 3 V +1 03/14/23, 12:19

  7. core-ci voted on patch set 3 V +1 03/14/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38918

  8. Torben Hansen voted on patch set 3 V +1 CR +1 03/14/23, 12:35

  9. Benni Mack voted on patch set 3 V +2 CR +2 03/20/23, 23:03

  10. Benni Mack merged patch set 4 03/20/23, 23:03