Review main Merged

78104[TASK] Use constructor property promotion in OpenDocumentController

Torben Hansen CR +2 V +2 Easy +2 −7 updated 03/13/23, 13:47

Commit message

This change adds constructor property promotion in ext:opendocs
`OpenDocumentController`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Torben Hansen uploaded patch set 1 03/12/23, 18:40

  2. core-ci voted on patch set 1 V +1 03/12/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38844

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/12/23, 19:26

  4. Oliver Klee voted on patch set 1 CR +1 03/12/23, 19:30

  5. Oli Bartsch commented on patch set 1 03/13/23, 12:21

    OpenDocumentController.php:35

    We could make them readonly.
  6. Oliver Klee commented on patch set 2 CR +1 V +1 03/13/23, 13:09

    Published edit on patch set 1.
  7. Oliver Klee commented on patch set 2 03/13/23, 13:09

    OpenDocumentController.php:35 Reply

    Done
  8. Oliver Klee voted on patch set 2 CR +1 03/13/23, 13:09

  9. core-ci voted on patch set 2 V +1 03/13/23, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38878

  10. Oli Bartsch voted on patch set 2 V +1 CR +1 03/13/23, 13:23

  11. Oliver Klee voted on patch set 2 V +1 03/13/23, 13:26

  12. Oli Bartsch voted on patch set 2 V +2 CR +2 03/13/23, 13:47

  13. Oli Bartsch merged patch set 3 03/13/23, 13:47