Review 11.5 Merged

78121[BUGFIX] Fix PHP 8 warnings in GifBuilder

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 03/14/23, 14:35

Commit message

Added some guards, isset(), to ensure that array keys
that aren't defined are accessed and throws PHP warnings.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Ralph Brugger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 03/14/23, 14:09

  2. Ralph Brugger voted on patch set 1 CR +1 03/14/23, 14:13

  3. Oliver Klee voted on patch set 1 CR +1 03/14/23, 14:16

  4. core-ci voted on patch set 1 V +1 03/14/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38929

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 03/14/23, 14:35

  6. Christian Kuhn merged patch set 2 03/14/23, 14:35