Review main Merged

78123[BUGFIX] Avoid clipped dropdowns in panels

Benjamin Kott CR +2 V +2 Easy +1 −2 updated 03/20/23, 09:03

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1214

  1. Benjamin Kott uploaded patch set 1 03/14/23, 14:22

  2. Benjamin Kott commented on patch set 1 03/14/23, 14:22

    can be validated in the scheduler module
  3. core-ci voted on patch set 1 V +1 03/14/23, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38933

  4. Markus Klein commented on patch set 1 03/14/23, 15:01

    Any side effects to expect, where other things within a .panel rely on the relative positioning?
  5. Benjamin Kott commented on patch set 1 03/15/23, 07:25

    Reply

    I would not have pushed the patch, if I was aware of something - not as far as I can see. If something pops up, will fix it as usual.
  6. Benni Mack voted on patch set 1 V +1 CR +1 03/15/23, 15:53

  7. Benjamin Kott uploaded patch set 2 CR +1 V +1 03/20/23, 08:35

  8. Benni Mack voted on patch set 2 V +1 CR +1 03/20/23, 08:36

  9. Oliver Hader voted on patch set 2 CR +1 03/20/23, 08:37

  10. Markus Klein commented on patch set 2 V +1 CR +1 03/20/23, 08:38

    Reply

    Ack
  11. Andreas Kienast voted on patch set 2 V +2 CR +2 03/20/23, 08:39

  12. Oliver Hader voted on patch set 2 V +1 03/20/23, 08:40

  13. core-ci voted on patch set 2 V +1 03/20/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39223

  14. Oliver Hader merged patch set 3 03/20/23, 09:03