78126[TASK] Mark several internal methods and properties protected in UserAuthentication
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php3+6 −3
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+48 −12
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+6 −3
- typo3/sysext/core/Classes/Compatibility/PublicMethodDeprecationTrait.php+1 −1
- typo3/sysext/core/Classes/Compatibility/PublicPropertyDeprecationTrait.php+1 −1
- typo3/sysext/core/Documentation/Changelog/12.4/Deprecation-100173-VariousMethodsAndPropertiesInUserAuthenticationClassesNowInternal.rst2new+77 −0
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php2+35 −11
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+35 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php+40 −0
Review log 2636
Show 611 earlier messages
-
Benni Mack uploaded patch set 1 03/14/23, 16:20
-
core-ci voted on patch set 1 V -1 03/14/23, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38938
-
Benni Mack uploaded patch set 2
V -103/14/23, 20:49 -
core-ci voted on patch set 2 V +1 03/14/23, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38946
-
Benni Mack uploaded patch set 3
V +103/15/23, 10:15 -
Benni Mack uploaded patch set 4 03/15/23, 10:30
-
core-ci voted on patch set 3 V -1 03/15/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38969
-
core-ci voted on patch set 4 V +1 03/15/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38971
-
Benni Mack updated the commit message in patch set 5
V +103/15/23, 11:28 -
core-ci voted on patch set 5 V +1 03/15/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38976
-
Oliver Klee commented on patch set 5 03/15/23, 11:53
-
Benni Mack commented on patch set 5 03/15/23, 13:08
FrontendBackendUserAuthentication.php:36ReplyI agree, but I took it from here: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Compatibility/PublicPropertyDeprecationTrait.php#L56 Looks like we should add this to our Deprecation policy list. "How to make a property/method protected" -
Benni Mack uploaded patch set 6
V +103/15/23, 19:32 -
Oliver Klee commented on patch set 6 03/15/23, 19:39
FrontendBackendUserAuthentication.php:36ReplyAck -
core-ci voted on patch set 6 V +1 03/15/23, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39003
-
Benni Mack rebased onto patch set 7
V +103/27/23, 20:25 -
core-ci voted on patch set 7 V +1 03/27/23, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39727
-
Benni Mack uploaded patch set 8
V +104/05/23, 14:37 -
core-ci voted on patch set 8 V +1 04/05/23, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40193
-
Oli Bartsch uploaded patch set 9
V +104/12/23, 10:51 -
Oliver Klee commented on patch set 9 04/12/23, 10:53
Deprecation-100173-VariousMethodsAndPropertiesInUserAuthenticationClassesNowInternal.rst:73… is thrown/issued. -
Oli Bartsch uploaded patch set 10 04/12/23, 10:57
-
Oliver Klee commented on patch set 11 04/12/23, 10:57
Published edit on patch set 10. -
Oliver Klee commented on patch set 11 04/12/23, 10:57
Deprecation-100173-VariousMethodsAndPropertiesInUserAuthenticationClassesNowInternal.rst:73ReplyDone -
Oliver Klee voted on patch set 11 CR +1 04/12/23, 10:57
-
core-ci voted on patch set 9 V +1 04/12/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40494
-
Georg Ringer voted on patch set 11 V +1 CR +1 04/12/23, 11:02
-
Oli Bartsch uploaded patch set 12
CR +1V +104/12/23, 11:04 -
Oli Bartsch uploaded patch set 13 04/12/23, 11:06
-
core-ci voted on patch set 13 V +1 04/12/23, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40499
-
Oli Bartsch voted on patch set 13 V +1 CR +1 04/12/23, 11:20
-
Oliver Klee voted on patch set 13 V +1 CR +1 04/12/23, 11:29
-
Georg Ringer voted on patch set 13 V +2 CR +2 04/12/23, 12:34
-
Georg Ringer merged patch set 14 04/12/23, 12:34
-
Oliver Hader commented on patch set 14 05/02/23, 15:57
FrontendUserAuthentication.php:182`\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::setSessionCookie()` checks this value, which seems to be always true for `FE_USER` -
Oliver Hader commented on patch set 14 05/02/23, 16:13
FrontendUserAuthentication.php:182ReplyForget it, I overlooked that is was `true` before... just was focussed on the change in v12...
FrontendBackendUserAuthentication.php:36