Review main Merged

78126[TASK] Mark several internal methods and properties protected in UserAuthentication

Benni Mack CR +2 V +2 Hard +249 −31 updated 04/21/26, 15:03

Commit message

To enable further refactorings and decoupling work,
several internal methods and properties in the
user authentication related classes are now
marked as @internal and set to "protected".

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2636

Show 611 earlier messages
  1. Benni Mack uploaded patch set 1 03/14/23, 16:20

  2. core-ci voted on patch set 1 V -1 03/14/23, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38938

  3. Benni Mack uploaded patch set 2 V -1 03/14/23, 20:49

  4. core-ci voted on patch set 2 V +1 03/14/23, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38946

  5. Benni Mack uploaded patch set 3 V +1 03/15/23, 10:15

  6. Benni Mack uploaded patch set 4 03/15/23, 10:30

  7. core-ci voted on patch set 3 V -1 03/15/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38969

  8. core-ci voted on patch set 4 V +1 03/15/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38971

  9. Benni Mack updated the commit message in patch set 5 V +1 03/15/23, 11:28

  10. core-ci voted on patch set 5 V +1 03/15/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38976

  11. Oliver Klee commented on patch set 5 03/15/23, 11:53

    FrontendBackendUserAuthentication.php:36

    Shouldn't this be `@internal` then? (Ditto for the other `@private` annotations.)
  1. Benni Mack commented on patch set 5 03/15/23, 13:08

    FrontendBackendUserAuthentication.php:36 Reply

    I agree, but I took it from here: https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Compatibility/PublicPropertyDeprecationTrait.php#L56 Looks like we should add this to our Deprecation policy list. "How to make a property/method protected"
  2. Benni Mack uploaded patch set 6 V +1 03/15/23, 19:32

  3. Oliver Klee commented on patch set 6 03/15/23, 19:39

    FrontendBackendUserAuthentication.php:36 Reply

    Ack
  4. core-ci voted on patch set 6 V +1 03/15/23, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39003

  5. Benni Mack rebased onto patch set 7 V +1 03/27/23, 20:25

  6. core-ci voted on patch set 7 V +1 03/27/23, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39727

  7. Benni Mack uploaded patch set 8 V +1 04/05/23, 14:37

  8. core-ci voted on patch set 8 V +1 04/05/23, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40193

  9. Oli Bartsch uploaded patch set 9 V +1 04/12/23, 10:51

  10. Oliver Klee commented on patch set 9 04/12/23, 10:53

    Deprecation-100173-VariousMethodsAndPropertiesInUserAuthenticationClassesNowInternal.rst:73

    … is thrown/issued.
  11. Oli Bartsch uploaded patch set 10 04/12/23, 10:57

  12. Oliver Klee commented on patch set 11 04/12/23, 10:57

    Published edit on patch set 10.
  13. Oliver Klee commented on patch set 11 04/12/23, 10:57

    Deprecation-100173-VariousMethodsAndPropertiesInUserAuthenticationClassesNowInternal.rst:73 Reply

    Done
  14. Oliver Klee voted on patch set 11 CR +1 04/12/23, 10:57

  15. core-ci voted on patch set 9 V +1 04/12/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40494

  16. Georg Ringer voted on patch set 11 V +1 CR +1 04/12/23, 11:02

  17. Oli Bartsch uploaded patch set 12 CR +1 V +1 04/12/23, 11:04

  18. Oli Bartsch uploaded patch set 13 04/12/23, 11:06

  19. core-ci voted on patch set 13 V +1 04/12/23, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40499

  20. Oli Bartsch voted on patch set 13 V +1 CR +1 04/12/23, 11:20

  21. Oliver Klee voted on patch set 13 V +1 CR +1 04/12/23, 11:29

  22. Georg Ringer voted on patch set 13 V +2 CR +2 04/12/23, 12:34

  23. Georg Ringer merged patch set 14 04/12/23, 12:34

  24. Oliver Hader commented on patch set 14 05/02/23, 15:57

    FrontendUserAuthentication.php:182

    `\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::setSessionCookie()` checks this value, which seems to be always true for `FE_USER`
  25. Oliver Hader commented on patch set 14 05/02/23, 16:13

    FrontendUserAuthentication.php:182 Reply

    Forget it, I overlooked that is was `true` before... just was focussed on the change in v12...