78127[TASK] Introduce Map data-structure
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1621
-
Oliver Hader uploaded patch set 1 03/14/23, 21:17
-
Oliver Hader uploaded patch set 2 03/14/23, 21:25
-
core-ci voted on patch set 1 V +1 03/14/23, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38947
-
core-ci voted on patch set 2 V +1 03/14/23, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38948
-
Benni Mack updated the commit message in patch set 3
V +103/14/23, 21:37 -
Benni Mack voted on patch set 3 V +1 CR +1 03/14/23, 21:37
-
Markus Klein updated the commit message in patch set 4
CR +1V +103/14/23, 21:41 -
Markus Klein commented on patch set 4 03/14/23, 21:44
What's the difference to https://www.php.net/manual/de/class.splobjectstorage.php ? -
core-ci voted on patch set 3 V +1 03/14/23, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38949
-
core-ci voted on patch set 4 V +1 03/14/23, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38952
-
Oliver Hader commented on patch set 4 03/14/23, 22:00
Reply
Good point, seems I got confused with not using `spl_object_id` like mentioned in https://wiki.php.net/rfc/weak_maps - thus, I did not consider SPL at all. -
Oliver Hader commented on patch set 4 CR -1 03/14/23, 22:02
I'll check the CSP stuff with SplObjectStorage... -
Oliver Hader commented on patch set 4 03/14/23, 22:17
`SplObjectStorage` has a strange behavior with `foreach`, see https://3v4l.org/gloDO#v8.1.16 -
Oliver Hader commented on patch set 4 03/14/23, 22:39
The hint on `SplObjectStorage` was good, by using the new `Map` as wrapper we get the benefits of the internal implementation in terms of speed and can make it flexible towards iterations with `foreach`. -
Oliver Hader uploaded patch set 5
CR -1V +103/14/23, 22:40 -
core-ci voted on patch set 5 V +1 03/14/23, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38953
-
Andreas Kienast voted on patch set 5 V +1 CR +1 03/15/23, 07:14
-
Benni Mack voted on patch set 5 V +1 CR +1 03/15/23, 07:29
-
Oliver Hader voted on patch set 5 V +2 CR +2 03/15/23, 08:53
-
Oliver Hader merged patch set 6 03/15/23, 08:53