Review main Merged

78129[TASK] Convert class ApplicationType to enum

Oliver Hader CR +2 V +2 Normal +44 −7 updated 03/15/23, 10:49

Commit message

Converting the class to an enum is possible since
 * the constructor is private,
 * property $type is not exposed,
 * public functions are kept.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Oliver Hader uploaded patch set 1 03/15/23, 10:20

  2. core-ci voted on patch set 1 V +1 03/15/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38970

  3. Oliver Hader updated the commit message in patch set 2 V +1 03/15/23, 10:40

  4. Benni Mack voted on patch set 2 V +1 CR +1 03/15/23, 10:42

  5. core-ci voted on patch set 2 V +1 03/15/23, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38972

  6. Georg Ringer voted on patch set 2 V +2 CR +2 03/15/23, 10:49

  7. Georg Ringer merged patch set 3 03/15/23, 10:49