78130[BUGFIX] Ensure `uid` is not updated when updating resources
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1419
-
TYPO3com uploaded patch set 1 03/15/23, 13:34
-
core-ci voted on patch set 1 V +1 03/15/23, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38984
-
Thomas Hohn updated the commit message in patch set 2
V +103/15/23, 13:45 -
core-ci voted on patch set 2 V +1 03/15/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38985
-
Oliver Klee commented on patch set 2 03/15/23, 14:15
Some lines are too long. On it. -
Oliver Klee updated the commit message in patch set 3
V +103/15/23, 14:15 -
Oliver Klee commented on patch set 3 03/15/23, 14:15
Reply
Done -
core-ci voted on patch set 3 V +1 03/15/23, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38988
-
Oliver Klee wrote 03/15/23, 14:26
Removed cc Oliver Klee. -
Benni Mack voted on patch set 3 CR +1 04/03/23, 08:45
-
Stefan Bürk commented on patch set 3 CR -1 04/06/23, 08:39
I guess we should look into it and try to handle this more generig in Connection->update() directly (getting PK info and ignore it there). Therefore, this "check" would match all places where the connection update method is used (and eventually also bulk update, but not checked yet). -
Benni Mack updated the commit message in patch set 4
CR +1V +105/03/23, 09:43 -
Benni Mack rebased onto patch set 5 07/05/23, 13:57
-
core-ci voted on patch set 5 V +1 07/05/23, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43525
-
Benni Mack voted on patch set 5 V +1 CR +1 07/05/23, 14:54
-
Benni Mack commented on patch set 5 07/05/23, 14:54
Reply
yes. but how about we fix this for the time being? -
Stefan Bürk commented on patch set 5 07/21/23, 20:46
Reply
ack. let's take that fix for now. Added it to my list of todo's. -
Stefan Bürk voted on patch set 5 V +2 CR +2 07/21/23, 20:47
-
Stefan Bürk merged patch set 6 07/21/23, 20:48