Review main Merged

78131[BUGFIX] Prevent submission of empty value in page title inline edit

Jochen Roth CR +2 V +2 Easy +2 −2 updated 03/15/23, 16:02

Commit message

Currently, it's possible to submit an empty page title in the
inline edit feature. If an empty title was submitted, the entire
element is gone.

This has been fixed by adding the 'required' attribute to
the input field.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Jochen Roth uploaded patch set 1 03/15/23, 14:42

  2. core-ci voted on patch set 1 V +1 03/15/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38989

  3. Jochen Roth updated the commit message in patch set 2 V +1 03/15/23, 14:51

  4. core-ci voted on patch set 2 V +1 03/15/23, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38990

  5. Jochen Roth updated the commit message in patch set 3 V +1 03/15/23, 15:19

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 03/15/23, 15:19

  7. core-ci voted on patch set 3 V +1 03/15/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38992

  8. Benni Mack voted on patch set 3 V +2 CR +2 03/15/23, 16:02

  9. Benni Mack merged patch set 4 03/15/23, 16:02