Review main Merged

78133[TASK] Cover "id" argument in TranslateViewHelperTest

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 03/15/23, 20:30

Commit message

Tests for the "key" argument were duplicated. This patch aligns the
comments with the actual input.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Nikita Hovratov uploaded patch set 1 03/15/23, 17:11

  2. core-ci voted on patch set 1 V +1 03/15/23, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38998

  3. Oliver Klee commented on patch set 1 03/15/23, 17:22

    TranslateViewHelperTest.php:89

    I'd like to have those as additional tests so that we don't lose the tests using `key`.
  4. Nikita Hovratov commented on patch set 1 03/15/23, 18:54

    TranslateViewHelperTest.php:89 Reply

    The cases were duplicated before. I just aligned the comment with the actual input.
  5. Nikita Hovratov updated the commit message in patch set 2 V +1 03/15/23, 18:56

  6. core-ci voted on patch set 2 V +1 03/15/23, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39001

  7. Benni Mack voted on patch set 2 V +1 CR +1 03/15/23, 19:11

  8. Oliver Klee voted on patch set 2 V +1 CR +1 03/15/23, 20:09

  9. Georg Ringer voted on patch set 2 V +2 CR +2 03/15/23, 20:30

  10. Georg Ringer merged patch set 3 03/15/23, 20:30