Review main Abandoned

78137[TASK] Deprecate metatag handling via PageRenderer

Georg Ringer CR 0 V 0 Hard +404 −87 updated 03/23/25, 23:35

Commit message

Deprecate the MetaTag handling in the PageRenderer in favor of the
MetaTag API.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 3552

Show 1727 earlier messages
  1. Georg Ringer uploaded patch set 1 03/16/23, 07:21

  2. core-ci voted on patch set 1 V -1 03/16/23, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39036

  3. Georg Ringer uploaded patch set 2 V -1 03/16/23, 08:52

  4. core-ci voted on patch set 2 V -1 03/16/23, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39040

  5. Georg Ringer uploaded patch set 3 V -1 03/16/23, 19:29

  6. core-ci voted on patch set 3 V +1 03/16/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39065

  7. Georg Ringer uploaded patch set 4 V +1 03/16/23, 19:56

  8. core-ci voted on patch set 4 V +1 03/16/23, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39068

  9. Georg Ringer uploaded patch set 5 V +1 03/16/23, 20:50

  10. core-ci voted on patch set 5 V -1 03/16/23, 21:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39071

  11. Georg Ringer uploaded patch set 6 V -1 03/17/23, 07:11

  12. core-ci voted on patch set 6 V +1 03/17/23, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39099

  13. Georg Ringer marked it ready for review 03/17/23, 09:13

  14. Oliver Klee commented on patch set 6 03/17/23, 09:22

    GenericMetaTagManager.php:128

    This change does not seem to be part of the deprecation change, but more like a bugfix that we might want to also backport to 11.5. Please let's have that in a separate change.
  15. Georg Ringer commented on patch set 6 03/17/23, 10:05

  16. Georg Ringer uploaded patch set 7 V +1 03/20/23, 18:07

  17. Oliver Klee commented on patch set 7 03/20/23, 18:09

    GenericMetaTagManager.php:128 Reply

    Done
  18. core-ci voted on patch set 7 V +1 03/20/23, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39267

  19. Benni Mack commented on patch set 7 03/20/23, 20:46

    one small remark, rest looks good so far.

    PageRenderer.php:347

    should we move this to the reset() method?
  20. Georg Ringer uploaded patch set 8 V +1 03/20/23, 21:02

  21. core-ci voted on patch set 8 V +1 03/20/23, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39279

  22. Benni Mack uploaded patch set 9 V +1 03/20/23, 21:34

  23. Benni Mack commented on patch set 9 V +1 CR +1 03/20/23, 21:34

    PageRenderer.php:347 Reply

    Done
  24. core-ci voted on patch set 9 V +1 03/20/23, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39280

  25. Simon Schaufelberger uploaded patch set 10 CR +1 V +1 08/14/23, 05:07

  26. Simon Schaufelberger voted on patch set 10 CR +1 08/14/23, 05:15

  27. core-ci voted on patch set 10 V -1 08/14/23, 05:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45464

  1. Chris Müller uploaded patch set 11 CR +1 V -1 08/14/23, 08:41

  2. core-ci voted on patch set 11 V -1 08/14/23, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45469

  3. Oliver Klee wrote 08/14/23, 09:43

    Removed cc Oliver Klee.
  4. Simon Schaufelberger uploaded patch set 12 V -1 08/15/23, 15:10

  5. core-ci voted on patch set 12 V -1 08/15/23, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45508

  6. Simon Schaufelberger uploaded patch set 13 V -1 08/15/23, 15:21

  7. core-ci voted on patch set 13 V +1 08/15/23, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45510

  8. Simon Schaufelberger voted on patch set 13 V +1 CR +1 08/15/23, 15:29

  9. Georg Ringer voted on patch set 13 V +1 CR +1 08/23/23, 19:07

  10. Torben Hansen voted on patch set 13 V +1 CR +1 08/26/23, 05:03

  11. Nikita Hovratov commented on patch set 13 CR -1 09/18/23, 14:12

    PageRenderer.php:725

    should be v14.0 as deprecated in v13
  12. Simon Schaufelberger uploaded patch set 14 CR +1 V +1 09/18/23, 14:50

  13. Simon Schaufelberger commented on patch set 14 09/18/23, 14:50

    PageRenderer.php:725 Reply

    Done
  14. Simon Schaufelberger uploaded patch set 15 09/18/23, 14:52

  15. Simon Schaufelberger voted on patch set 15 V +1 CR +1 09/18/23, 14:52

  16. core-ci voted on patch set 15 V +1 09/18/23, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46678

  17. core-ci voted on patch set 14 V +1 09/18/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46677

  18. Georg Ringer uploaded patch set 16 CR +1 V +1 10/09/23, 18:32

  19. core-ci voted on patch set 16 V +1 10/09/23, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47619

  20. Simon Schaufelberger voted on patch set 16 V +1 CR +1 10/09/23, 19:08

  21. Benjamin Franzke commented on patch set 16 CR -2 10/20/23, 08:58

    I have to disagree with a deprecation. Why? The MetaTagManager API isn't a nice API and has exactly the same design problems as PageRenderer (being a stateful singleton, representing current render state, that needs to be (un)serialized for cached requests). I would not like developers having to migrate to this API that *may* need to be changed in v14 again. So let's not remove these simple passthrough methods, they do not "hurt" us right now and only create additional word for developers.
  22. Simon Schaufelberger commented on patch set 16 12/22/23, 00:49

    Reply Unresolved

    Wouldn't it be ok to use the "better" API and then migrate the whole thing altogether once the MetaTagManager is stateless? Then we could do it propertly in v13 or v14 for example.
  23. Simon Schaufelberger uploaded patch set 17 CR +1 V +1 12/22/23, 00:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  24. core-ci voted on patch set 17 V +1 12/22/23, 00:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50889

  25. Benni Mack abandoned the change 03/23/25, 23:35

    won't do it. See bnf's comments!