Review main Merged

78142[TASK] Simplify ValidatorResolver::buildBaseValidatorConjunction()

Alexander Schnitzler CR +2 V +2 Normal +94 −80 updated 03/21/23, 09:52

Commit message

Prior to this change, buildBaseValidatorConjunction() was responsible
for initializing $this->baseValidatorConjunctions[$indexKey] and
additionally adding an object validator if the given target type
was a class name.

Now, the initialization takes place in getBaseValidatorConjunction()
already and buildBaseValidatorConjunction() is only called if target
types is a class name.

That way, buildBaseValidatorConjunction() gets rid of an if-statement
and the whole method looses one indentation.

Additionally, buildBaseValidatorConjunction() is guaranteed to get
passed a class-string, so argument name $targetClassName actually
makes sense.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5