Review main Merged

78144[TASK] Simplify DataMapFactory::setRelations()

Alexander Schnitzler CR +2 V +2 Normal +37 −26 updated 03/20/23, 10:02

Commit message

In order to have this method more readable, elseif statements
are broken apart and replaced with early returns.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Alexander Schnitzler uploaded patch set 1 03/17/23, 07:58

  2. Alexander Schnitzler wrote 03/17/23, 07:59

    Topic set to extbase
  3. core-ci voted on patch set 1 V +1 03/17/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39103

  4. Markus Klein voted on patch set 1 V +1 CR +1 03/20/23, 09:36

  5. Benni Mack voted on patch set 1 V +2 CR +2 03/20/23, 10:02

  6. Benni Mack merged patch set 2 03/20/23, 10:02