Review main Merged

78148[TASK] Make RequestBuilder stateless

Alexander Schnitzler CR +2 V +2 Hard +477 −110 updated 03/20/23, 21:54

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2126

Show 1 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 03/17/23, 11:40

  1. Alexander Schnitzler wrote 03/17/23, 11:40

    Topic set to extbase
  2. core-ci voted on patch set 1 V -1 03/17/23, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39118

  3. Alexander Schnitzler uploaded patch set 2 V -1 03/17/23, 13:21

  4. core-ci voted on patch set 2 V -1 03/17/23, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39125

  5. Alexander Schnitzler uploaded patch set 3 V -1 03/17/23, 13:47

  6. core-ci voted on patch set 3 V +1 03/17/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39130

  7. Alexander Schnitzler marked it ready for review 03/17/23, 14:17

  8. Benni Mack voted on patch set 3 CR +1 03/20/23, 10:03

  9. Alexander Schnitzler commented on patch set 3 03/20/23, 10:04

    RequestBuilderDefaultValues.php:25

    I forgot to make this private.
  10. Oliver Klee commented on patch set 3 03/20/23, 10:42

    I like this simplification!

    RequestBuilderDefaultValues.php:28

    We need a `class-string` annotation for this property, and `non-empty-string` for the other string properties.

    RequestBuilderDefaultValues.php:48

    For the making this more explicit (mostly for the human reader), please let's use `!is_string`.

    RequestBuilderDefaultValues.php:51

    For the making this more explicit (mostly for the human reader), please let's use `!is_string`.

    RequestBuilderDefaultValuesTest.php:26

    Why not a const?
  11. Alexander Schnitzler commented on patch set 3 03/20/23, 10:52

    RequestBuilderDefaultValuesTest.php:26 Reply

    I am not used to array const, that's all. I'm fine with changing this.
  12. Alexander Schnitzler uploaded patch set 4 CR +1 V +1 03/20/23, 13:36

  13. Alexander Schnitzler uploaded patch set 5 03/20/23, 13:39

  14. Alexander Schnitzler commented on patch set 4 03/20/23, 13:39

    RequestBuilderDefaultValues.php:28 Reply

    Can you please verify if Chat GPT did the job properly? ;)

    RequestBuilderDefaultValues.php:48 Reply

    Done

    RequestBuilderDefaultValues.php:51 Reply

    Done

    RequestBuilderDefaultValuesTest.php:26 Reply

    Done
  15. Alexander Schnitzler commented on patch set 5 03/20/23, 13:39

    RequestBuilderDefaultValues.php:25 Reply

    Done
  16. core-ci voted on patch set 4 V +1 03/20/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39237

  17. core-ci voted on patch set 5 V +1 03/20/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39238

  18. Oliver Klee commented on patch set 5 03/20/23, 14:24

    RequestBuilderDefaultValues.php:28 Reply

    Done
  19. Benni Mack commented on patch set 5 V +1 CR +1 03/20/23, 15:22

    very good improvement
  20. Markus Klein commented on patch set 5 03/20/23, 16:37

    RequestBuilder.php:208

    Naming: For my taste "getAllowedControllerActions" is enough.
  21. Alexander Schnitzler commented on patch set 5 03/20/23, 17:24

    RequestBuilder.php:208 Reply

    Yep, I have the same taste but getAllowedControllerActions is already taken as a getter to return all allowed controller actions of all controllers. I am fine with renaming either of those. What do you prefer?
  22. Markus Klein commented on patch set 5 CR +1 03/20/23, 19:56

    RequestBuilder.php:208 Reply

    Oh damn.. I did not see this. Keep things as they are now. All good. Thanks.
  23. Markus Klein voted on patch set 5 V +1 03/20/23, 19:59

  24. Benni Mack voted on patch set 5 V +2 CR +2 03/20/23, 21:53

  25. Benni Mack merged patch set 6 03/20/23, 21:54